* [PATCH] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc
@ 2021-06-19 12:13 Alex Bee
2021-06-19 21:58 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bee @ 2021-06-19 12:13 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Markus Reichl, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, Alex Bee
Re-add the regulator-always-on property for vcc_sdio which supplies sdmmc,
since it gets disabled during reboot now and the bootrom expects it to be
enabled when booting from SD card. This makes rebooting impossible in that
case and requires a hard reset to boot again.
Fixes: 04a0077fdb19 ("arm64: dts: rockchip: Remove always-on properties from regulator nodes on rk3399-roc-pc.")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index c172f5a803e7..da3021dc0ff3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -389,6 +389,7 @@ regulator-state-mem {
vcc_sdio: LDO_REG4 {
regulator-name = "vcc_sdio";
+ regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3000000>;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc
2021-06-19 12:13 [PATCH] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc Alex Bee
@ 2021-06-19 21:58 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2021-06-19 21:58 UTC (permalink / raw)
To: Alex Bee
Cc: Heiko Stuebner, devicetree, Rob Herring, linux-rockchip,
linux-arm-kernel, linux-kernel, Markus Reichl
On Sat, 19 Jun 2021 14:13:06 +0200, Alex Bee wrote:
> Re-add the regulator-always-on property for vcc_sdio which supplies sdmmc,
> since it gets disabled during reboot now and the bootrom expects it to be
> enabled when booting from SD card. This makes rebooting impossible in that
> case and requires a hard reset to boot again.
Applied, thanks!
[1/1] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc
commit: eb607cd4957fb0ef97beb2a8293478be6a54240a
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-19 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 12:13 [PATCH] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc Alex Bee
2021-06-19 21:58 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).