* [PATCH v3] tools: bpftool: close va_list 'ap' by va_end()
@ 2021-07-06 1:35 Gu Shengxian
2021-07-06 7:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Gu Shengxian @ 2021-07-06 1:35 UTC (permalink / raw)
To: ast, daniel, andrii; +Cc: netdev, bpf, linux-kernel, Gu Shengxian
From: Gu Shengxian <gushengxian@yulong.com>
va_list 'ap' was opened but not closed by va_end(). It should be
closed by va_end() before return.
According to suggestion of Daniel Borkmann <daniel@iogearbox.net>.
Signed-off-by: Gu Shengxian <gushengxian@yulong.com>
---
tools/bpf/bpftool/jit_disasm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index e7e7eee9f172..24734f2249d6 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -43,11 +43,13 @@ static int fprintf_json(void *out, const char *fmt, ...)
{
va_list ap;
char *s;
+ int err;
va_start(ap, fmt);
- if (vasprintf(&s, fmt, ap) < 0)
- return -1;
+ err = vasprintf(&s, fmt, ap);
va_end(ap);
+ if (err < 0)
+ return -1;
if (!oper_count) {
int i;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] tools: bpftool: close va_list 'ap' by va_end()
2021-07-06 1:35 [PATCH v3] tools: bpftool: close va_list 'ap' by va_end() Gu Shengxian
@ 2021-07-06 7:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-06 7:20 UTC (permalink / raw)
To: Gu Shengxian; +Cc: ast, daniel, andrii, netdev, bpf, linux-kernel, gushengxian
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Mon, 5 Jul 2021 18:35:43 -0700 you wrote:
> From: Gu Shengxian <gushengxian@yulong.com>
>
> va_list 'ap' was opened but not closed by va_end(). It should be
> closed by va_end() before return.
>
> According to suggestion of Daniel Borkmann <daniel@iogearbox.net>.
> Signed-off-by: Gu Shengxian <gushengxian@yulong.com>
>
> [...]
Here is the summary with links:
- [v3] tools: bpftool: close va_list 'ap' by va_end()
https://git.kernel.org/bpf/bpf/c/519f9d19e135
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-06 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 1:35 [PATCH v3] tools: bpftool: close va_list 'ap' by va_end() Gu Shengxian
2021-07-06 7:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).