* Re: [PATCH] ASoC: codecs: wcd938x: fix returnvar.cocci warnings
2021-06-29 13:29 ` [PATCH] ASoC: codecs: wcd938x: fix returnvar.cocci warnings kernel test robot
@ 2021-06-30 7:16 ` Souptick Joarder
2021-07-12 10:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Souptick Joarder @ 2021-06-30 7:16 UTC (permalink / raw)
To: kernel test robot
Cc: Srinivas Kandagatla, kbuild-all, Linux Memory Management List,
Mark Brown, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
On Tue, Jun 29, 2021 at 6:59 PM kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> sound/soc/codecs/wcd938x.c:1628:5-8: Unneeded variable: "ret". Return "0" on line 1656
> sound/soc/codecs/wcd938x.c:1871:5-8: Unneeded variable: "ret". Return "0" on line 1907
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> Fixes: 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig")
> CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 73748627df83aab934c81332ca83a44ab8c7b3e3
> commit: 04544222886881cb0865040dcdf747fe7e025947 [8525/14055] ASoC: codecs: wcd938x: add audio routing and Kconfig
> :::::: branch date: 4 hours ago
> :::::: commit date: 2 weeks ago
>
> wcd938x.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/sound/soc/codecs/wcd938x.c
> +++ b/sound/soc/codecs/wcd938x.c
> @@ -1625,7 +1625,6 @@ static int wcd938x_codec_aux_dac_event(s
> {
> struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
> - int ret = 0;
>
> switch (event) {
> case SND_SOC_DAPM_PRE_PMU:
> @@ -1653,7 +1652,7 @@ static int wcd938x_codec_aux_dac_event(s
> WCD938X_ANA_RX_DIV4_CLK_EN_MASK, 0);
> break;
> }
> - return ret;
> + return 0;
>
> }
>
> @@ -1868,7 +1867,6 @@ static int wcd938x_codec_enable_aux_pa(s
> struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
> int hph_mode = wcd938x->hph_mode;
> - int ret = 0;
>
> switch (event) {
> case SND_SOC_DAPM_PRE_PMU:
> @@ -1904,7 +1902,7 @@ static int wcd938x_codec_enable_aux_pa(s
> WCD938X_EN_CUR_DET_MASK, 1);
> break;
> }
> - return ret;
> + return 0;
> }
>
> static int wcd938x_codec_enable_ear_pa(struct snd_soc_dapm_widget *w,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: codecs: wcd938x: fix returnvar.cocci warnings
2021-06-29 13:29 ` [PATCH] ASoC: codecs: wcd938x: fix returnvar.cocci warnings kernel test robot
2021-06-30 7:16 ` Souptick Joarder
@ 2021-07-12 10:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-07-12 10:46 UTC (permalink / raw)
To: Srinivas Kandagatla, kernel test robot
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, linux-kernel,
Liam Girdwood, kbuild-all, alsa-devel,
Linux Memory Management List
On Tue, 29 Jun 2021 21:29:09 +0800, kernel test robot wrote:
> sound/soc/codecs/wcd938x.c:1628:5-8: Unneeded variable: "ret". Return "0" on line 1656
> sound/soc/codecs/wcd938x.c:1871:5-8: Unneeded variable: "ret". Return "0" on line 1907
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: wcd938x: fix returnvar.cocci warnings
commit: 4d0b79ec9eb81b227c8ae211b7f159bd7194d9ae
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread