* [PATCH 2/2] ASoC: amd: reverse stop sequence for stoneyridge platform
2021-07-16 12:30 [PATCH 1/2] ASoC: soc-pcm: add a flag to reverse the stop sequence Vijendar Mukunda
@ 2021-07-16 12:30 ` Vijendar Mukunda
2021-07-16 15:05 ` [PATCH 1/2] ASoC: soc-pcm: add a flag to reverse the stop sequence Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Vijendar Mukunda @ 2021-07-16 12:30 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Alexander.Deucher, nartemiev, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, amistry, Vijendar Mukunda, Vijendar Mukunda,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto,
Chuhong Yuan, open list
For Stoneyridge platform, it is required to invoke DMA driver stop
first rather than invoking DWC I2S controller stop.
Enable dai_link structure stop_dma_fist flag to reverse the stop
sequence.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/amd/acp-da7219-max98357a.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 84e3906abd4f..9449fb40a956 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -576,6 +576,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = {
| SND_SOC_DAIFMT_CBM_CFM,
.init = cz_rt5682_init,
.dpcm_playback = 1,
+ .stop_dma_first = 1,
.ops = &cz_rt5682_play_ops,
SND_SOC_DAILINK_REG(designware1, rt5682, platform),
},
@@ -585,6 +586,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = {
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
| SND_SOC_DAIFMT_CBM_CFM,
.dpcm_capture = 1,
+ .stop_dma_first = 1,
.ops = &cz_rt5682_cap_ops,
SND_SOC_DAILINK_REG(designware2, rt5682, platform),
},
@@ -594,6 +596,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = {
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
| SND_SOC_DAIFMT_CBM_CFM,
.dpcm_playback = 1,
+ .stop_dma_first = 1,
.ops = &cz_rt5682_max_play_ops,
SND_SOC_DAILINK_REG(designware3, mx, platform),
},
@@ -604,6 +607,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = {
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
| SND_SOC_DAIFMT_CBM_CFM,
.dpcm_capture = 1,
+ .stop_dma_first = 1,
.ops = &cz_rt5682_dmic0_cap_ops,
SND_SOC_DAILINK_REG(designware3, adau, platform),
},
@@ -614,6 +618,7 @@ static struct snd_soc_dai_link cz_dai_5682_98357[] = {
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
| SND_SOC_DAIFMT_CBM_CFM,
.dpcm_capture = 1,
+ .stop_dma_first = 1,
.ops = &cz_rt5682_dmic1_cap_ops,
SND_SOC_DAILINK_REG(designware2, adau, platform),
},
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ASoC: soc-pcm: add a flag to reverse the stop sequence
2021-07-16 12:30 [PATCH 1/2] ASoC: soc-pcm: add a flag to reverse the stop sequence Vijendar Mukunda
2021-07-16 12:30 ` [PATCH 2/2] ASoC: amd: reverse stop sequence for stoneyridge platform Vijendar Mukunda
@ 2021-07-16 15:05 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-07-16 15:05 UTC (permalink / raw)
To: Vijendar Mukunda, alsa-devel
Cc: Mark Brown, Alexander.Deucher, Peter Ujfalusi, amistry,
Jaroslav Kysela, nartemiev, Takashi Iwai, open list,
Liam Girdwood, Vijendar Mukunda, Sunil-kumar.Dommati,
Pierre-Louis Bossart, Basavaraj.Hiregoudar
On Fri, 16 Jul 2021 18:00:12 +0530, Vijendar Mukunda wrote:
> On stream stop, currently CPU DAI stop sequence invoked first
> followed by DMA. For Few platforms, it is required to stop the
> DMA first before stopping CPU DAI.
>
> Introduced new flag in dai_link structure for reordering stop sequence.
> Based on flag check, ASoC core will re-order the stop sequence.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: soc-pcm: add a flag to reverse the stop sequence
commit: 59dd33f82dc0975c55d3d46801e7ca45532d7673
[2/2] ASoC: amd: reverse stop sequence for stoneyridge platform
commit: 7883490cba002121a5870e786a1dc0acce5e1caf
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread