linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
@ 2021-09-03  7:35 Dinghao Liu
  2021-09-04 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2021-09-03  7:35 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Shahed Shaikh, Manish Chopra, GR-Linux-NIC-Dev, David S. Miller,
	Jakub Kicinski, Sony Chacko, Anirban Chakraborty, netdev,
	linux-kernel

Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.

Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
index 3d61a767a8a3..09f20c794754 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
@@ -437,7 +437,6 @@ int qlcnic_pinit_from_rom(struct qlcnic_adapter *adapter)
 	QLCWR32(adapter, QLCNIC_CRB_PEG_NET_4 + 0x3c, 1);
 	msleep(20);
 
-	qlcnic_rom_unlock(adapter);
 	/* big hammer don't reset CAM block on reset */
 	QLCWR32(adapter, QLCNIC_ROMUSB_GLB_SW_RESET, 0xfeffffff);
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
  2021-09-03  7:35 [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom Dinghao Liu
@ 2021-09-04 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-04 10:00 UTC (permalink / raw)
  To: Dinghao Liu
  Cc: kjlu, shshaikh, manishc, GR-Linux-NIC-Dev, davem, kuba,
	sony.chacko, anirban.chakraborty, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri,  3 Sep 2021 15:35:43 +0800 you wrote:
> Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
> in qlcnic_pinit_from_rom(), but remains its corresponding
> unlock function, which is odd. I'm not very sure whether the
> lock is missing, or the unlock is redundant. This bug is
> suggested by a static analysis tool, please advise.
> 
> Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> 
> [...]

Here is the summary with links:
  - qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
    https://git.kernel.org/netdev/net/c/9ddbc2a00d7f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-04 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03  7:35 [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom Dinghao Liu
2021-09-04 10:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).