* [PATCH] irqchip/irqchip-goldfish-pic: select GENERIC_IRQ_CHIP to fix build
@ 2021-09-05 16:25 Randy Dunlap
2021-09-22 13:40 ` [irqchip: irq/irqchip-fixes] irqchip/goldfish-pic: Select " irqchip-bot for Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-09-05 16:25 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Miodrag Dinic,
Geert Uytterhoeven, Bartosz Golaszewski, Thomas Gleixner,
Marc Zyngier, Goran Ferenc, Aleksandar Markovic
irq-goldfish-pic uses GENERIC_IRQ_CHIP interfaces so select that symbol
to fix build errors.
Fixes these build errors:
mips-linux-ld: drivers/irqchip/irq-goldfish-pic.o: in function `goldfish_pic_of_init':
irq-goldfish-pic.c:(.init.text+0xc0): undefined reference to `irq_alloc_generic_chip'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0xf4): undefined reference to `irq_gc_unmask_enable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0xf8): undefined reference to `irq_gc_unmask_enable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x100): undefined reference to `irq_gc_mask_disable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x104): undefined reference to `irq_gc_mask_disable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x11c): undefined reference to `irq_setup_generic_chip'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x168): undefined reference to `irq_remove_generic_chip'
Fixes: 4235ff50cf98 ("irqchip/irq-goldfish-pic: Add Goldfish PIC driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210903.orig/drivers/irqchip/Kconfig
+++ linux-next-20210903/drivers/irqchip/Kconfig
@@ -409,6 +409,7 @@ config MESON_IRQ_GPIO
config GOLDFISH_PIC
bool "Goldfish programmable interrupt controller"
depends on MIPS && (GOLDFISH || COMPILE_TEST)
+ select GENERIC_IRQ_CHIP
select IRQ_DOMAIN
help
Say yes here to enable Goldfish interrupt controller driver used
^ permalink raw reply [flat|nested] 2+ messages in thread* [irqchip: irq/irqchip-fixes] irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build
2021-09-05 16:25 [PATCH] irqchip/irqchip-goldfish-pic: select GENERIC_IRQ_CHIP to fix build Randy Dunlap
@ 2021-09-22 13:40 ` irqchip-bot for Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: irqchip-bot for Randy Dunlap @ 2021-09-22 13:40 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Miodrag Dinic,
Geert Uytterhoeven, Bartosz Golaszewski, Thomas Gleixner,
Marc Zyngier, Goran Ferenc, Aleksandar Markovic
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: 969ac78db78c723a24e9410666b457cc1b0cb3c3
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/969ac78db78c723a24e9410666b457cc1b0cb3c3
Author: Randy Dunlap <rdunlap@infradead.org>
AuthorDate: Sun, 05 Sep 2021 09:25:19 -07:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Wed, 22 Sep 2021 14:33:09 +01:00
irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build
irq-goldfish-pic uses GENERIC_IRQ_CHIP interfaces so select that symbol
to fix build errors.
Fixes these build errors:
mips-linux-ld: drivers/irqchip/irq-goldfish-pic.o: in function `goldfish_pic_of_init':
irq-goldfish-pic.c:(.init.text+0xc0): undefined reference to `irq_alloc_generic_chip'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0xf4): undefined reference to `irq_gc_unmask_enable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0xf8): undefined reference to `irq_gc_unmask_enable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x100): undefined reference to `irq_gc_mask_disable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x104): undefined reference to `irq_gc_mask_disable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x11c): undefined reference to `irq_setup_generic_chip'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x168): undefined reference to `irq_remove_generic_chip'
Fixes: 4235ff50cf98 ("irqchip/irq-goldfish-pic: Add Goldfish PIC driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210905162519.21507-1-rdunlap@infradead.org
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 4d5924e..aca7b59 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -409,6 +409,7 @@ config MESON_IRQ_GPIO
config GOLDFISH_PIC
bool "Goldfish programmable interrupt controller"
depends on MIPS && (GOLDFISH || COMPILE_TEST)
+ select GENERIC_IRQ_CHIP
select IRQ_DOMAIN
help
Say yes here to enable Goldfish interrupt controller driver used
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-22 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 16:25 [PATCH] irqchip/irqchip-goldfish-pic: select GENERIC_IRQ_CHIP to fix build Randy Dunlap
2021-09-22 13:40 ` [irqchip: irq/irqchip-fixes] irqchip/goldfish-pic: Select " irqchip-bot for Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).