* [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference
@ 2021-09-30 11:51 John Garry
2021-09-30 12:10 ` Arnd Bergmann
2021-10-05 4:33 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: John Garry @ 2021-09-30 11:51 UTC (permalink / raw)
To: linux, jejb, martin.petersen
Cc: hare, linux-arm-kernel, linux-scsi, linux-kernel, arnd, John Garry
Commit 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
mistakenly introduced a reference to function scsi_cmd_to_tag(). This
function does not exist as it was removed from an earlier series version
when I upstreamed the named commit - originally authored By Hannes - but
this reference still remained.
Fix by replacing the reference to scsi_cmd_to_tag() with
scsi_cmd_to_rq(scsi_scmd)->tag, which scsi_cmd_to_tag() was a wrapper for.
Fixes: 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: John Garry <john.garry@huawei.com>
diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm/acornscsi.c
index b4cb5fb19998..0cc62c1b0825 100644
--- a/drivers/scsi/arm/acornscsi.c
+++ b/drivers/scsi/arm/acornscsi.c
@@ -1776,7 +1776,7 @@ int acornscsi_reconnect_finish(AS_Host *host)
host->scsi.disconnectable = 0;
if (host->SCpnt->device->id == host->scsi.reconnected.target &&
host->SCpnt->device->lun == host->scsi.reconnected.lun &&
- scsi_cmd_to_tag(host->SCpnt) == host->scsi.reconnected.tag) {
+ scsi_cmd_to_rq(host->SCpnt)->tag == host->scsi.reconnected.tag) {
#if (DEBUG & (DEBUG_QUEUES|DEBUG_DISCON))
DBG(host->SCpnt, printk("scsi%d.%c: reconnected",
host->host->host_no, acornscsi_target(host)));
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference
2021-09-30 11:51 [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference John Garry
@ 2021-09-30 12:10 ` Arnd Bergmann
2021-10-05 4:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-09-30 12:10 UTC (permalink / raw)
To: John Garry
Cc: Russell King - ARM Linux, James E.J. Bottomley,
Martin K. Petersen, Hannes Reinecke, Linux ARM, linux-scsi,
Linux Kernel Mailing List, Arnd Bergmann
On Thu, Sep 30, 2021 at 1:51 PM John Garry <john.garry@huawei.com> wrote:
>
> Commit 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
> mistakenly introduced a reference to function scsi_cmd_to_tag(). This
> function does not exist as it was removed from an earlier series version
> when I upstreamed the named commit - originally authored By Hannes - but
> this reference still remained.
>
> Fix by replacing the reference to scsi_cmd_to_tag() with
> scsi_cmd_to_rq(scsi_scmd)->tag, which scsi_cmd_to_tag() was a wrapper for.
>
> Fixes: 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: John Garry <john.garry@huawei.com>
Thanks, that fixes the build regression and looks sensible.
Tested-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference
2021-09-30 11:51 [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference John Garry
2021-09-30 12:10 ` Arnd Bergmann
@ 2021-10-05 4:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-10-05 4:33 UTC (permalink / raw)
To: jejb, John Garry, linux
Cc: Martin K . Petersen, linux-kernel, hare, linux-scsi, arnd,
linux-arm-kernel
On Thu, 30 Sep 2021 19:51:57 +0800, John Garry wrote:
> Commit 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
> mistakenly introduced a reference to function scsi_cmd_to_tag(). This
> function does not exist as it was removed from an earlier series version
> when I upstreamed the named commit - originally authored By Hannes - but
> this reference still remained.
>
> Fix by replacing the reference to scsi_cmd_to_tag() with
> scsi_cmd_to_rq(scsi_scmd)->tag, which scsi_cmd_to_tag() was a wrapper for.
>
> [...]
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: acornscsi: Remove scsi_cmd_to_tag() reference
https://git.kernel.org/mkp/scsi/c/c5336400ca8b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-05 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 11:51 [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference John Garry
2021-09-30 12:10 ` Arnd Bergmann
2021-10-05 4:33 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).