* [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory
@ 2021-10-11 7:11 Faiyaz Mohammed
2021-10-11 8:34 ` David Hildenbrand
0 siblings, 1 reply; 5+ messages in thread
From: Faiyaz Mohammed @ 2021-10-11 7:11 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel, david; +Cc: guptap, Faiyaz Mohammed
From: Faiyaz Mohammed <faiyazm@codeaurora.org>
For INITRD and initmem memory is reserved through "memblock_reserve"
during boot up but it is free via "free_reserved_area" instead
of "memblock_free".
For example:
[ 0.294848] Freeing initrd memory: 12K.
[ 0.696688] Freeing unused kernel memory: 4096K.
To get the start and end address of the above freed memory and to account
proper memblock added pr_debug log in "free_reserved_area".
After adding log:
[ 0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
[ 0.294848] Freeing initrd memory: 12K.
[ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
[ 0.696688] Freeing unused kernel memory: 4096K.
Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
---
changes in v2:
- To avoid confusion, remove the memblock_dbg print and drop the
memblock_free string, now using pr_debug to print the address ranges.
mm/page_alloc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 668edb1..395df3f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8153,6 +8153,11 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
if (pages && s)
pr_info("Freeing %s memory: %ldK\n", s, K(pages));
+#ifdef CONFIG_HAVE_MEMBLOCK
+ pr_debug("%#016llx-%#016llx %pS\n",
+ __pa(start), __pa(end), (void *)_RET_IP_);
+#endif
+
return pages;
}
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory
2021-10-11 7:11 [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory Faiyaz Mohammed
@ 2021-10-11 8:34 ` David Hildenbrand
2021-10-13 8:45 ` Faiyaz Mohammed
0 siblings, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2021-10-11 8:34 UTC (permalink / raw)
To: Faiyaz Mohammed, akpm, linux-mm, linux-kernel; +Cc: guptap, Faiyaz Mohammed
On 11.10.21 09:11, Faiyaz Mohammed wrote:
> From: Faiyaz Mohammed <faiyazm@codeaurora.org>
>
> For INITRD and initmem memory is reserved through "memblock_reserve"
> during boot up but it is free via "free_reserved_area" instead
> of "memblock_free".
> For example:
> [ 0.294848] Freeing initrd memory: 12K.
> [ 0.696688] Freeing unused kernel memory: 4096K.
>
> To get the start and end address of the above freed memory and to account
> proper memblock added pr_debug log in "free_reserved_area".
> After adding log:
> [ 0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
> [ 0.294848] Freeing initrd memory: 12K.
> [ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
> [ 0.696688] Freeing unused kernel memory: 4096K.
>
> Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
> ---
> changes in v2:
> - To avoid confusion, remove the memblock_dbg print and drop the
> memblock_free string, now using pr_debug to print the address ranges.
>
> mm/page_alloc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 668edb1..395df3f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8153,6 +8153,11 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
> if (pages && s)
> pr_info("Freeing %s memory: %ldK\n", s, K(pages));
>
> +#ifdef CONFIG_HAVE_MEMBLOCK
> + pr_debug("%#016llx-%#016llx %pS\n",
> + __pa(start), __pa(end), (void *)_RET_IP_);
> +#endif
> +
Are we missing parentheses that the code indentation implies?
Further, I think we want to use "%pa" instead of "%llx" and
eventually drop the CONFIG_HAVE_MEMBLOCK dependency. Maybe
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b37435c274cf..e7946e5ca094 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8097,6 +8097,8 @@ EXPORT_SYMBOL(adjust_managed_page_count);
unsigned long free_reserved_area(void *start, void *end, int poison, const char *s)
{
+ const phys_addr_t pstart = __pa(start);
+ const phys_addr_t pend = __pa(end);
void *pos;
unsigned long pages = 0;
@@ -8125,9 +8127,11 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
free_reserved_page(page);
}
- if (pages && s)
+ if (pages && s) {
pr_info("Freeing %s memory: %ldK\n",
s, pages << (PAGE_SHIFT - 10));
+ pr_debug("[%pa-%pa] %pS\n", &pstart, &pend, (void *)_RET_IP_);
+ }
return pages;
}
--
Thanks,
David / dhildenb
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory
2021-10-11 8:34 ` David Hildenbrand
@ 2021-10-13 8:45 ` Faiyaz Mohammed
0 siblings, 0 replies; 5+ messages in thread
From: Faiyaz Mohammed @ 2021-10-13 8:45 UTC (permalink / raw)
To: David Hildenbrand, Faiyaz Mohammed, akpm, linux-mm, linux-kernel; +Cc: guptap
On 10/11/2021 2:04 PM, David Hildenbrand wrote:
> On 11.10.21 09:11, Faiyaz Mohammed wrote:
>> From: Faiyaz Mohammed <faiyazm@codeaurora.org>
>>
>> For INITRD and initmem memory is reserved through "memblock_reserve"
>> during boot up but it is free via "free_reserved_area" instead
>> of "memblock_free".
>> For example:
>> [ 0.294848] Freeing initrd memory: 12K.
>> [ 0.696688] Freeing unused kernel memory: 4096K.
>>
>> To get the start and end address of the above freed memory and to account
>> proper memblock added pr_debug log in "free_reserved_area".
>> After adding log:
>> [ 0.294837] 0x00000083600000-0x00000083603000
>> free_initrd_mem+0x20/0x28
>> [ 0.294848] Freeing initrd memory: 12K.
>> [ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
>> [ 0.696688] Freeing unused kernel memory: 4096K.
>>
>> Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
>> ---
>> changes in v2:
>> - To avoid confusion, remove the memblock_dbg print and drop the
>> memblock_free string, now using pr_debug to print the address ranges.
>>
>> mm/page_alloc.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 668edb1..395df3f 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -8153,6 +8153,11 @@ unsigned long free_reserved_area(void *start,
>> void *end, int poison, const char
>> if (pages && s)
>> pr_info("Freeing %s memory: %ldK\n", s, K(pages));
>> +#ifdef CONFIG_HAVE_MEMBLOCK
>> + pr_debug("%#016llx-%#016llx %pS\n",
>> + __pa(start), __pa(end), (void *)_RET_IP_);
>> +#endif
>> +
>
> Are we missing parentheses that the code indentation implies?
> Further, I think we want to use "%pa" instead of "%llx" and
> eventually drop the CONFIG_HAVE_MEMBLOCK dependency. Maybe
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b37435c274cf..e7946e5ca094 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8097,6 +8097,8 @@ EXPORT_SYMBOL(adjust_managed_page_count);
>
> unsigned long free_reserved_area(void *start, void *end, int poison,
> const char *s)
> {
> + const phys_addr_t pstart = __pa(start);
> + const phys_addr_t pend = __pa(end);
> void *pos;
> unsigned long pages = 0;
>
> @@ -8125,9 +8127,11 @@ unsigned long free_reserved_area(void *start,
> void *end, int poison, const char
> free_reserved_page(page);
> }
>
> - if (pages && s)
> + if (pages && s) {
> pr_info("Freeing %s memory: %ldK\n",
> s, pages << (PAGE_SHIFT - 10));
> + pr_debug("[%pa-%pa] %pS\n", &pstart, &pend, (void
> *)_RET_IP_);
> + }
>
> return pages;
> }
> Sure, I will update it and push again.
Thanks and regards,
Mohammed Faiyaz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory
@ 2021-10-11 6:55 Faiyaz Mohammed
2021-10-11 6:58 ` Faiyaz Mohammed
0 siblings, 1 reply; 5+ messages in thread
From: Faiyaz Mohammed @ 2021-10-11 6:55 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel, david; +Cc: guptap, Faiyaz Mohammed
From: Faiyaz Mohammed <faiyazm@codeaurora.org>
For INITRD and initmem memory is reserved through "memblock_reserve"
during boot up but it is free via "free_reserved_area" instead
of "memblock_free".
For example:
[ 0.294848] Freeing initrd memory: 12K.
[ 0.696688] Freeing unused kernel memory: 4096K.
To get the start and end address of the above freed memory and to account
proper memblock added pr_debug log in "free_reserved_area".
After adding log:
[ 0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
[ 0.294848] Freeing initrd memory: 12K.
[ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
[ 0.696688] Freeing unused kernel memory: 4096K.
Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
---
mm/page_alloc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 668edb1..8a1929d4 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8153,6 +8153,11 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
if (pages && s)
pr_info("Freeing %s memory: %ldK\n", s, K(pages));
+#ifdef CONFIG_HAVE_MEMBLOCK
+ memblock_dbg("memblock_free: [%#016llx-%#016llx] %pS\n",
+ __pa(start), __pa(end), (void *)_RET_IP_);
+#endif
+
return pages;
}
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory
2021-10-11 6:55 Faiyaz Mohammed
@ 2021-10-11 6:58 ` Faiyaz Mohammed
0 siblings, 0 replies; 5+ messages in thread
From: Faiyaz Mohammed @ 2021-10-11 6:58 UTC (permalink / raw)
To: Faiyaz Mohammed, akpm, linux-mm, linux-kernel, david; +Cc: guptap
Please ignore this patch.
On 10/11/2021 12:25 PM, Faiyaz Mohammed wrote:
> From: Faiyaz Mohammed <faiyazm@codeaurora.org>
>
> For INITRD and initmem memory is reserved through "memblock_reserve"
> during boot up but it is free via "free_reserved_area" instead
> of "memblock_free".
> For example:
> [ 0.294848] Freeing initrd memory: 12K.
> [ 0.696688] Freeing unused kernel memory: 4096K.
>
> To get the start and end address of the above freed memory and to account
> proper memblock added pr_debug log in "free_reserved_area".
> After adding log:
> [ 0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
> [ 0.294848] Freeing initrd memory: 12K.
> [ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
> [ 0.696688] Freeing unused kernel memory: 4096K.
>
> Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
> ---
> mm/page_alloc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 668edb1..8a1929d4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8153,6 +8153,11 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
> if (pages && s)
> pr_info("Freeing %s memory: %ldK\n", s, K(pages));
>
> +#ifdef CONFIG_HAVE_MEMBLOCK
> + memblock_dbg("memblock_free: [%#016llx-%#016llx] %pS\n",
> + __pa(start), __pa(end), (void *)_RET_IP_);
> +#endif
> +
> return pages;
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-13 8:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 7:11 [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory Faiyaz Mohammed
2021-10-11 8:34 ` David Hildenbrand
2021-10-13 8:45 ` Faiyaz Mohammed
-- strict thread matches above, loose matches on Subject: below --
2021-10-11 6:55 Faiyaz Mohammed
2021-10-11 6:58 ` Faiyaz Mohammed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).