* [PATCH] net: korina: select CRC32
@ 2021-10-12 15:25 Vegard Nossum
2021-10-12 16:21 ` Florian Fainelli
2021-10-13 20:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Vegard Nossum @ 2021-10-12 15:25 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: Florian Fainelli, netdev, linux-kernel, Vegard Nossum, Arnd Bergmann
Fix the following build/link error by adding a dependency on the CRC32
routines:
ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
korina.c:(.text+0x1af): undefined reference to `crc32_le'
Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
drivers/net/ethernet/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index d796684ec9ca0..412ae3e43ffb7 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -100,6 +100,7 @@ config JME
config KORINA
tristate "Korina (IDT RC32434) Ethernet support"
depends on MIKROTIK_RB532 || COMPILE_TEST
+ select CRC32
select MII
help
If you have a Mikrotik RouterBoard 500 or IDT RC32434
--
2.23.0.718.g5ad94255a8
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: korina: select CRC32
2021-10-12 15:25 [PATCH] net: korina: select CRC32 Vegard Nossum
@ 2021-10-12 16:21 ` Florian Fainelli
2021-10-13 20:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-10-12 16:21 UTC (permalink / raw)
To: Vegard Nossum, David S. Miller, Jakub Kicinski
Cc: netdev, linux-kernel, Arnd Bergmann
On 10/12/21 8:25 AM, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
> korina.c:(.text+0x1af): undefined reference to `crc32_le'
>
> Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Acked-by: Florian fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: korina: select CRC32
2021-10-12 15:25 [PATCH] net: korina: select CRC32 Vegard Nossum
2021-10-12 16:21 ` Florian Fainelli
@ 2021-10-13 20:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-13 20:40 UTC (permalink / raw)
To: Vegard Nossum; +Cc: davem, kuba, f.fainelli, netdev, linux-kernel, arnd
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 12 Oct 2021 17:25:09 +0200 you wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
> korina.c:(.text+0x1af): undefined reference to `crc32_le'
>
> Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
>
> [...]
Here is the summary with links:
- net: korina: select CRC32
https://git.kernel.org/netdev/net/c/427f974d9727
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-13 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 15:25 [PATCH] net: korina: select CRC32 Vegard Nossum
2021-10-12 16:21 ` Florian Fainelli
2021-10-13 20:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).