* [PATCH] media: ccs: replace snprintf in show functions with sysfs_emit
@ 2021-10-15 6:49 Qing Wang
2021-10-15 22:36 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-10-15 6:49 UTC (permalink / raw)
To: Sakari Ailus, Mauro Carvalho Chehab, linux-media, linux-kernel; +Cc: Qing Wang
show() must not use snprintf() when formatting the value to be
returned to user space.
Fix the following coccicheck warning:
drivers/media/i2c/ccs/ccs-core.c:2717: WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com>
---
drivers/media/i2c/ccs/ccs-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index a9403a2..21a156d 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -2715,11 +2715,11 @@ ccs_sysfs_ident_read(struct device *dev, struct device_attribute *attr,
struct ccs_module_info *minfo = &sensor->minfo;
if (minfo->mipi_manufacturer_id)
- return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
+ return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
minfo->mipi_manufacturer_id, minfo->model_id,
minfo->revision_number) + 1;
else
- return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
+ return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
minfo->smia_manufacturer_id, minfo->model_id,
minfo->revision_number) + 1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: ccs: replace snprintf in show functions with sysfs_emit
2021-10-15 6:49 [PATCH] media: ccs: replace snprintf in show functions with sysfs_emit Qing Wang
@ 2021-10-15 22:36 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2021-10-15 22:36 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Qing Wang, Sakari Ailus, linux-kernel,
linux-media
Cc: Qing Wang
Hello,
Quoting Qing Wang (2021-10-15 07:49:22)
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the following coccicheck warning:
> drivers/media/i2c/ccs/ccs-core.c:2717: WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
> drivers/media/i2c/ccs/ccs-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
> index a9403a2..21a156d 100644
> --- a/drivers/media/i2c/ccs/ccs-core.c
> +++ b/drivers/media/i2c/ccs/ccs-core.c
> @@ -2715,11 +2715,11 @@ ccs_sysfs_ident_read(struct device *dev, struct device_attribute *attr,
What version of the kernel is this patch against?
I can't find the direct line mapping for this in either the linux-media
tree or torvalds master branch (closest match at
https://git.linuxtv.org/media_tree.git/tree/drivers/media/i2c/ccs/ccs-core.c#n2754)
Ah: https://lore.kernel.org/all/20210603071750.11594-1-thunder.leizhen@huawei.com/
updated this, so I suspect this patch has been submitted against perhaps
a v5.14 kernel? It would be best to rebase and repost against the latest
branch of https://git.linuxtv.org/media_tree.git
> struct ccs_module_info *minfo = &sensor->minfo;
>
> if (minfo->mipi_manufacturer_id)
> - return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
> + return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
> minfo->mipi_manufacturer_id, minfo->model_id,
> minfo->revision_number) + 1;
This change looks good, but I think it might be better to re-indent the
minfo lines to match as well...
> else
> - return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
> + return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
> minfo->smia_manufacturer_id, minfo->model_id,
> minfo->revision_number) + 1;
here as well of course.
--
Kieran
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-15 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 6:49 [PATCH] media: ccs: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-15 22:36 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).