* [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF
@ 2021-08-28 17:57 Kees Cook
2021-09-30 8:49 ` Tony Lindgren
2021-10-24 15:39 ` [tip: timers/core] " tip-bot2 for Kees Cook
0 siblings, 2 replies; 3+ messages in thread
From: Kees Cook @ 2021-08-28 17:57 UTC (permalink / raw)
To: Tony Lindgren
Cc: Kees Cook, kernel test robot, Daniel Lezcano, Keerthy,
Sebastian Reichel, Ladislav Michl, Grygorii Strashko, linux-omap,
Thomas Gleixner, linux-kernel, linux-hardening
When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
Cc: Tony Lindgren <tony@atomide.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Keerthy <j-keerthy@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Ladislav Michl <ladis@linux-mips.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org
Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 0f5e3983951a..08f8cb944a2a 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -24,6 +24,7 @@ config I8253_LOCK
config OMAP_DM_TIMER
bool
+ select TIMER_OF
config CLKBLD_I8253
def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF
2021-08-28 17:57 [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF Kees Cook
@ 2021-09-30 8:49 ` Tony Lindgren
2021-10-24 15:39 ` [tip: timers/core] " tip-bot2 for Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2021-09-30 8:49 UTC (permalink / raw)
To: Kees Cook
Cc: kernel test robot, Daniel Lezcano, Keerthy, Sebastian Reichel,
Ladislav Michl, Grygorii Strashko, linux-omap, Thomas Gleixner,
linux-kernel, linux-hardening
* Kees Cook <keescook@chromium.org> [210828 17:58]:
> When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
> due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
> CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> Cc: Ladislav Michl <ladis@linux-mips.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: linux-omap@vger.kernel.org
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Kees Cook <keescook@chromium.org>
Sorry for the delay, I just noticed I never replied earlier:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..08f8cb944a2a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -24,6 +24,7 @@ config I8253_LOCK
>
> config OMAP_DM_TIMER
> bool
> + select TIMER_OF
>
> config CLKBLD_I8253
> def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: timers/core] clocksource/drivers/timer-ti-dm: Select TIMER_OF
2021-08-28 17:57 [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF Kees Cook
2021-09-30 8:49 ` Tony Lindgren
@ 2021-10-24 15:39 ` tip-bot2 for Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Kees Cook @ 2021-10-24 15:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: kernel test robot, Tony Lindgren, Daniel Lezcano, Keerthy,
Sebastian Reichel, Ladislav Michl, Grygorii Strashko, linux-omap,
Kees Cook, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: eda9a4f7af6ee47e9e131f20e4f8a41a97379293
Gitweb: https://git.kernel.org/tip/eda9a4f7af6ee47e9e131f20e4f8a41a97379293
Author: Kees Cook <keescook@chromium.org>
AuthorDate: Sat, 28 Aug 2021 10:57:47 -07:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 21 Oct 2021 14:18:53 +02:00
clocksource/drivers/timer-ti-dm: Select TIMER_OF
When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
Cc: Tony Lindgren <tony@atomide.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Keerthy <j-keerthy@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Ladislav Michl <ladis@linux-mips.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org
Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20210828175747.3777891-1-keescook@chromium.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index ac56b56..e71ac54 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -24,6 +24,7 @@ config I8253_LOCK
config OMAP_DM_TIMER
bool
+ select TIMER_OF
config CLKBLD_I8253
def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-24 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-28 17:57 [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF Kees Cook
2021-09-30 8:49 ` Tony Lindgren
2021-10-24 15:39 ` [tip: timers/core] " tip-bot2 for Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).