linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benson Leung <bleung@google.com>
To: linux-kernel@vger.kernel.org, Prashant Malani <pmalani@chromium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC struct for features
Date: Sun, 31 Oct 2021 16:01:41 -0700	[thread overview]
Message-ID: <163572120352.2079946.6960520137860452667.b4-ty@chromium.org> (raw)
In-Reply-To: <20211004170716.86601-1-pmalani@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Hi Prashant,

On Mon, 4 Oct 2021 10:07:09 -0700, Prashant Malani wrote:
> The Chrome EC's features are returned through an
> ec_response_get_features struct, but they are stored in an independent
> array. Although the two are effectively the same at present (2 unsigned
> 32 bit ints), there is the possibility that they could go out of sync.
> Avoid this by only using the EC struct to store the features.

Applied, thanks!

[1/2] platform/chrome: cros_ec_proto: Use EC struct for features
      commit: 7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71
[2/2] platform/chrome: cros_ec_proto: Use ec_command for check_features
      commit: 297d34e73d491a3edbd6e8c31d33ec90447a908b

Best regards,

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2021-10-31 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 17:07 [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC struct for features Prashant Malani
2021-10-04 17:07 ` [PATCH 2/2] platform/chrome: cros_ec_proto: Use ec_command for check_features Prashant Malani
2021-10-31 23:01 ` Benson Leung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163572120352.2079946.6960520137860452667.b4-ty@chromium.org \
    --to=bleung@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=gustavoars@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).