* Re: [PATCH net] net: ethernet: lantiq_etop: Fix compilation error
2021-11-09 22:23 [PATCH net] net: ethernet: lantiq_etop: Fix compilation error Aleksander Jan Bajkowski
@ 2021-11-10 1:33 ` Randy Dunlap
2021-11-10 14:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-11-10 1:33 UTC (permalink / raw)
To: Aleksander Jan Bajkowski, davem, kuba, arnd, jgg, netdev, linux-kernel
Cc: kernel test robot
On 11/9/21 2:23 PM, Aleksander Jan Bajkowski wrote:
> This fixes the error detected when compiling the driver.
>
> Fixes: 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> drivers/net/ethernet/lantiq_etop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index 2258e3f19161..6433c909c6b2 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
> @@ -262,7 +262,7 @@ ltq_etop_hw_init(struct net_device *dev)
> /* enable crc generation */
> ltq_etop_w32(PPE32_CGEN, LQ_PPE32_ENET_MAC_CFG);
>
> - ltq_dma_init_port(DMA_PORT_ETOP, priv->tx_burst_len, rx_burst_len);
> + ltq_dma_init_port(DMA_PORT_ETOP, priv->tx_burst_len, priv->rx_burst_len);
>
> for (i = 0; i < MAX_DMA_CHAN; i++) {
> int irq = LTQ_DMA_CH0_INT + i;
>
Hi Aleksander,
That does indeed fix the first build problem that kernel test robot reported.
I was hoping that you would address the others also (quoting here):
drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_probe':
>> drivers/net/ethernet/lantiq_etop.c:673:15: error: implicit declaration of function 'device_property_read_u32' [-Werror=implicit-function-declaration]
673 | err = device_property_read_u32(&pdev->dev, "lantiq,tx-burst-length", &priv->tx_burst_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/lantiq_etop.c: At top level:
drivers/net/ethernet/lantiq_etop.c:730:1: warning: no previous prototype for 'init_ltq_etop' [-Wmissing-prototypes]
730 | init_ltq_etop(void)
| ^~~~~~~~~~~~~
drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_hw_init':
drivers/net/ethernet/lantiq_etop.c:276:25: warning: ignoring return value of 'request_irq' declared with attribute 'warn_unused_result' [-Wunused-result]
276 | request_irq(irq, ltq_etop_dma_irq, 0, "etop_tx", priv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/lantiq_etop.c:284:25: warning: ignoring return value of 'request_irq' declared with attribute 'warn_unused_result' [-Wunused-result]
284 | request_irq(irq, ltq_etop_dma_irq, 0, "etop_rx", priv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
If not, I can send the patch that I have prepared.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: ethernet: lantiq_etop: Fix compilation error
2021-11-09 22:23 [PATCH net] net: ethernet: lantiq_etop: Fix compilation error Aleksander Jan Bajkowski
2021-11-10 1:33 ` Randy Dunlap
@ 2021-11-10 14:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-10 14:50 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: davem, kuba, arnd, jgg, rdunlap, netdev, linux-kernel, lkp
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 9 Nov 2021 23:23:54 +0100 you wrote:
> This fixes the error detected when compiling the driver.
>
> Fixes: 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> drivers/net/ethernet/lantiq_etop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: ethernet: lantiq_etop: Fix compilation error
https://git.kernel.org/netdev/net/c/68eabc348148
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread