linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] gfs2 fixes for v5.16-rc2
@ 2021-11-17 23:36 Andreas Gruenbacher
  2021-11-17 23:55 ` Linus Torvalds
  2021-11-17 23:58 ` pr-tracker-bot
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Gruenbacher @ 2021-11-17 23:36 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Andreas Gruenbacher, cluster-devel, linux-kernel

Hi Linus,

please consider pulling the following gfs2 fixes for -rc2.  The one thing that
stands out is this commit:

  gfs2: Prevent endless loops in gfs2_file_buffered_write

We have a choice here between the proper fix in iomap_write_iter and
generic_perform_write and this patch, which is just a workaround.  I've tried
to get your feedback on this before:

  https://lore.kernel.org/all/20211110174457.533866-1-agruenba@redhat.com/

To me, it seems to be too late for the proper fix for v5.16 now; please advise
if you think otherwise.

Thanks,
Andreas


The following changes since commit 78805cbe5d72ad27a56962a8072edbcb45ca1180:

  Merge tag 'gfs2-v5.15-rc5-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2021-11-02 12:35:04 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.16-rc2-fixes

for you to fetch changes up to 554c577cee95bdc1d03d9f457e57dc96eb791845:

  gfs2: Prevent endless loops in gfs2_file_buffered_write (2021-11-10 18:22:37 +0100)

----------------------------------------------------------------
Fixes in gfs2:
* The current iomap_file_buffered_write behavior of failing the entire
  write when part of the user buffer cannot be faulted in leads to an
  endless loop in gfs2.  Work around that in gfs2 for now.
* Various other bugs all over the place.

----------------------------------------------------------------
Andreas Gruenbacher (5):
      gfs2: Only dereference i->iov when iter_is_iovec(i)
      gfs2: Fix atomic bug in gfs2_instantiate
      gfs2: Fix length of holes reported at end-of-file
      gfs2: Fix "Introduce flag for glock holder auto-demotion"
      gfs2: Prevent endless loops in gfs2_file_buffered_write

Bob Peterson (1):
      gfs2: release iopen glock early in evict

 fs/gfs2/bmap.c  |  2 +-
 fs/gfs2/file.c  |  9 ++++++---
 fs/gfs2/glock.c | 12 ++++--------
 fs/gfs2/super.c | 14 +++++++-------
 4 files changed, 18 insertions(+), 19 deletions(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL] gfs2 fixes for v5.16-rc2
  2021-11-17 23:36 [GIT PULL] gfs2 fixes for v5.16-rc2 Andreas Gruenbacher
@ 2021-11-17 23:55 ` Linus Torvalds
  2021-11-17 23:58 ` pr-tracker-bot
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2021-11-17 23:55 UTC (permalink / raw)
  To: Andreas Gruenbacher; +Cc: cluster-devel, Linux Kernel Mailing List

On Wed, Nov 17, 2021 at 3:37 PM Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> We have a choice here between the proper fix in iomap_write_iter and
> generic_perform_write and this patch, which is just a workaround.  I've tried
> to get your feedback on this before:

Well, you did get Catalin's feedback, and I didn't have any strong
opinions on it, so..

I do think that iomap_write_iter() should be fixed, but I also agree
with your "by now too late", so I've pulled your gfs2 workaround.

          Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL] gfs2 fixes for v5.16-rc2
  2021-11-17 23:36 [GIT PULL] gfs2 fixes for v5.16-rc2 Andreas Gruenbacher
  2021-11-17 23:55 ` Linus Torvalds
@ 2021-11-17 23:58 ` pr-tracker-bot
  1 sibling, 0 replies; 3+ messages in thread
From: pr-tracker-bot @ 2021-11-17 23:58 UTC (permalink / raw)
  To: Andreas Gruenbacher
  Cc: Linus Torvalds, Andreas Gruenbacher, cluster-devel, linux-kernel

The pull request you sent on Thu, 18 Nov 2021 00:36:56 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.16-rc2-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/42eb8fdac2fc5d62392dcfcf0253753e821a97b0

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-17 23:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 23:36 [GIT PULL] gfs2 fixes for v5.16-rc2 Andreas Gruenbacher
2021-11-17 23:55 ` Linus Torvalds
2021-11-17 23:58 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).