* [PATCH net v1] devlink: Don't throw an error if flash notification sent before devlink visible
@ 2021-11-17 14:49 Leon Romanovsky
2021-11-18 4:29 ` Jakub Kicinski
2021-11-18 11:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Leon Romanovsky @ 2021-11-17 14:49 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: Leon Romanovsky, Danielle Ratson, Jiri Pirko, linux-kernel,
netdev, Amit Cohen
From: Leon Romanovsky <leonro@nvidia.com>
The mlxsw driver calls to various devlink flash routines even before
users can get any access to the devlink instance itself. For example,
mlxsw_core_fw_rev_validate() one of such functions.
__mlxsw_core_bus_device_register
-> mlxsw_core_fw_rev_validate
-> mlxsw_core_fw_flash
-> mlxfw_firmware_flash
-> mlxfw_status_notify
-> devlink_flash_update_status_notify
-> __devlink_flash_update_notify
-> WARN_ON(...)
It causes to the WARN_ON to trigger warning about devlink not registered.
Fixes: cf530217408e ("devlink: Notify users when objects are accessible")
Reported-by: Danielle Ratson <danieller@nvidia.com>
Tested-by: Danielle Ratson <danieller@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
v1:
* Used Jakub's suggestion to silently drop flash notifications if
devlink is not visible yet.
* Used right person for Reported and Tested tags.
v0: https://lore.kernel.org/all/1d750b6f4991c16995c4d0927b709eb23647ff85.1636999616.git.leonro@nvidia.com
---
net/core/devlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 5ba4f9434acd..5ad72dbfcd07 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -4229,7 +4229,9 @@ static void __devlink_flash_update_notify(struct devlink *devlink,
WARN_ON(cmd != DEVLINK_CMD_FLASH_UPDATE &&
cmd != DEVLINK_CMD_FLASH_UPDATE_END &&
cmd != DEVLINK_CMD_FLASH_UPDATE_STATUS);
- WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
+
+ if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
+ return;
msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
if (!msg)
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] devlink: Don't throw an error if flash notification sent before devlink visible
2021-11-17 14:49 [PATCH net v1] devlink: Don't throw an error if flash notification sent before devlink visible Leon Romanovsky
@ 2021-11-18 4:29 ` Jakub Kicinski
2021-11-18 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-11-18 4:29 UTC (permalink / raw)
To: Leon Romanovsky
Cc: David S . Miller, Leon Romanovsky, Danielle Ratson, Jiri Pirko,
linux-kernel, netdev, Amit Cohen
On Wed, 17 Nov 2021 16:49:09 +0200 Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The mlxsw driver calls to various devlink flash routines even before
> users can get any access to the devlink instance itself. For example,
> mlxsw_core_fw_rev_validate() one of such functions.
>
> __mlxsw_core_bus_device_register
> -> mlxsw_core_fw_rev_validate
> -> mlxsw_core_fw_flash
> -> mlxfw_firmware_flash
> -> mlxfw_status_notify
> -> devlink_flash_update_status_notify
> -> __devlink_flash_update_notify
> -> WARN_ON(...)
>
> It causes to the WARN_ON to trigger warning about devlink not registered.
>
> Fixes: cf530217408e ("devlink: Notify users when objects are accessible")
> Reported-by: Danielle Ratson <danieller@nvidia.com>
> Tested-by: Danielle Ratson <danieller@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] devlink: Don't throw an error if flash notification sent before devlink visible
2021-11-17 14:49 [PATCH net v1] devlink: Don't throw an error if flash notification sent before devlink visible Leon Romanovsky
2021-11-18 4:29 ` Jakub Kicinski
@ 2021-11-18 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-18 11:40 UTC (permalink / raw)
To: Leon Romanovsky
Cc: davem, kuba, leonro, danieller, jiri, linux-kernel, netdev, amcohen
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 17 Nov 2021 16:49:09 +0200 you wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The mlxsw driver calls to various devlink flash routines even before
> users can get any access to the devlink instance itself. For example,
> mlxsw_core_fw_rev_validate() one of such functions.
>
> __mlxsw_core_bus_device_register
> -> mlxsw_core_fw_rev_validate
> -> mlxsw_core_fw_flash
> -> mlxfw_firmware_flash
> -> mlxfw_status_notify
> -> devlink_flash_update_status_notify
> -> __devlink_flash_update_notify
> -> WARN_ON(...)
>
> [...]
Here is the summary with links:
- [net,v1] devlink: Don't throw an error if flash notification sent before devlink visible
https://git.kernel.org/netdev/net/c/fec1faf221f6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-18 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 14:49 [PATCH net v1] devlink: Don't throw an error if flash notification sent before devlink visible Leon Romanovsky
2021-11-18 4:29 ` Jakub Kicinski
2021-11-18 11:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).