[PATCH] firmware: arm_scmi: Fix type error assignment in voltage protocol

[PATCH] firmware: arm_scmi: Fix type error assignment in voltage protocol

[Cristian Marussi]

Fix incorrect type assignment error reported by sparse as:

drivers/firmware/arm_scmi/voltage.c:159:42: warning: incorrect type in assignment (different base types)
drivers/firmware/arm_scmi/voltage.c:159:42: expected restricted __le32 [usertype] level_index
drivers/firmware/arm_scmi/voltage.c:159:42: got unsigned int [usertype] desc_index

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 2add5cacff353 ("firmware: arm_scmi: Add voltage domain management protocol support")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
 drivers/firmware/arm_scmi/voltage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/voltage.c b/drivers/firmware/arm_scmi/voltage.c
index a5048956a0be..ac08e819088b 100644
--- a/drivers/firmware/arm_scmi/voltage.c
+++ b/drivers/firmware/arm_scmi/voltage.c
@@ -156,7 +156,7 @@ static int scmi_voltage_descriptors_get(const struct scmi_protocol_handle *ph,
 			int cnt;
 
 			cmd->domain_id = cpu_to_le32(v->id);
-			cmd->level_index = desc_index;
+			cmd->level_index = cpu_to_le32(desc_index);
 			ret = ph->xops->do_xfer(ph, tl);
 			if (ret)
 				break;
-- 
2.17.1

[PATCH] firmware: arm_scmi: Fix type error in sensor protocol

[Cristian Marussi]

Fix incorrect type error reported by sparse as:

drivers/firmware/arm_scmi/sensors.c:640:28: warning: incorrect type in argument 1 (different base types)
drivers/firmware/arm_scmi/sensors.c:640:28: expected unsigned int [usertype] val
drivers/firmware/arm_scmi/sensors.c:640:28: got restricted __le32 [usertype]

Fixes: 7b83c5f410889 ("firmware: arm_scmi: Add SCMI v3.0 sensor configuration support")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
 drivers/firmware/arm_scmi/sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c
index 308471586381..cdbb287bd8bc 100644
--- a/drivers/firmware/arm_scmi/sensors.c
+++ b/drivers/firmware/arm_scmi/sensors.c
@@ -637,7 +637,7 @@ static int scmi_sensor_config_get(const struct scmi_protocol_handle *ph,
 	if (ret)
 		return ret;
 
-	put_unaligned_le32(cpu_to_le32(sensor_id), t->tx.buf);
+	put_unaligned_le32(sensor_id, t->tx.buf);
 	ret = ph->xops->do_xfer(ph, t);
 	if (!ret) {
 		struct sensors_info *si = ph->get_priv(ph);
-- 
2.17.1

Re: [PATCH] firmware: arm_scmi: Fix type error in sensor protocol

[Sudeep Holla]

On Mon, 15 Nov 2021 15:40:43 +0000, Cristian Marussi wrote:
> Fix incorrect type error reported by sparse as:
> 
> drivers/firmware/arm_scmi/sensors.c:640:28: warning: incorrect type in argument 1 (different base types)
> drivers/firmware/arm_scmi/sensors.c:640:28: expected unsigned int [usertype] val
> drivers/firmware/arm_scmi/sensors.c:640:28: got restricted __le32 [usertype]
> 
> 
> [...]

Applied to sudeep.holla/linux (for-next/scmi), thanks!

[1/1] firmware: arm_scmi: Fix type error in sensor protocol
      https://git.kernel.org/sudeep.holla/c/bd074e5039

--
Regards,
Sudeep

Re: [PATCH] firmware: arm_scmi: Fix type error assignment in voltage protocol

[Sudeep Holla]

On Mon, 15 Nov 2021 15:40:42 +0000, Cristian Marussi wrote:
> Fix incorrect type assignment error reported by sparse as:
> 
> drivers/firmware/arm_scmi/voltage.c:159:42: warning: incorrect type in assignment (different base types)
> drivers/firmware/arm_scmi/voltage.c:159:42: expected restricted __le32 [usertype] level_index
> drivers/firmware/arm_scmi/voltage.c:159:42: got unsigned int [usertype] desc_index
> 
> 
> [...]

Applied to sudeep.holla/linux (for-next/scmi), thanks!

[1/1] firmware: arm_scmi: Fix type error assignment in voltage protocol
      https://git.kernel.org/sudeep.holla/c/026d9835b6

--
Regards,
Sudeep