linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tip-bot2 for Mark Rutland" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Michal Simek <michal.simek@xilinx.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: core/entry] microblaze: Snapshot thread flags
Date: Tue, 30 Nov 2021 23:08:40 -0000	[thread overview]
Message-ID: <163831372065.11128.18395285019076351046.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20211129130653.2037928-8-mark.rutland@arm.com>

The following commit has been merged into the core/entry branch of tip:

Commit-ID:     e538c5849143a7f0aa97006cd45ce4c0c26d0744
Gitweb:        https://git.kernel.org/tip/e538c5849143a7f0aa97006cd45ce4c0c26d0744
Author:        Mark Rutland <mark.rutland@arm.com>
AuthorDate:    Mon, 29 Nov 2021 13:06:49 
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 01 Dec 2021 00:06:44 +01:00

microblaze: Snapshot thread flags

Some thread flags can be set remotely, and so even when IRQs are disabled,
the flags can change under our feet. Generally this is unlikely to cause a
problem in practice, but it is somewhat unsound, and KCSAN will
legitimately warn that there is a data race.

To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.

Convert them all to the new flag accessor helpers.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20211129130653.2037928-8-mark.rutland@arm.com

---
 arch/microblaze/kernel/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c
index fc61eb0..23e8a93 100644
--- a/arch/microblaze/kernel/signal.c
+++ b/arch/microblaze/kernel/signal.c
@@ -283,7 +283,7 @@ static void do_signal(struct pt_regs *regs, int in_syscall)
 #ifdef DEBUG_SIG
 	pr_info("do signal: %p %d\n", regs, in_syscall);
 	pr_info("do signal2: %lx %lx %ld [%lx]\n", regs->pc, regs->r1,
-			regs->r12, current_thread_info()->flags);
+			regs->r12, read_thread_flags());
 #endif
 
 	if (get_signal(&ksig)) {

  reply	other threads:[~2021-11-30 23:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 13:06 [PATCH v8 00/11] thread_info: use helpers to snapshot thread flags Mark Rutland
2021-11-29 13:06 ` [PATCH v8 01/11] thread_info: add " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] thread_info: Add " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 02/11] entry: " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] entry: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 03/11] sched: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] sched: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 04/11] alpha: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] alpha: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 05/11] arm: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] ARM: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 06/11] arm64: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] arm64: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 07/11] microblaze: snapshot " Mark Rutland
2021-11-30 23:08   ` tip-bot2 for Mark Rutland [this message]
2021-11-29 13:06 ` [PATCH v8 08/11] openrisc: " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] openrisc: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 09/11] powerpc: avoid discarding flags in system_call_exception() Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] powerpc: Avoid " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 10/11] powerpc: snapshot thread flags Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] powerpc: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 11/11] x86: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] x86: Snapshot " tip-bot2 for Mark Rutland
  -- strict thread matches above, loose matches on Subject: below --
2021-11-17 16:30 [PATCHv7 07/11] microblaze: snapshot " Mark Rutland
2021-11-26 20:22 ` [tip: core/entry] microblaze: Snapshot " tip-bot2 for Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163831372065.11128.18395285019076351046.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=paulmck@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).