linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: i2c: Fix inconsistent indenting
@ 2021-12-02  8:39 Jiapeng Chong
  2021-12-02  9:47 ` Daniel Scally
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-12-02  8:39 UTC (permalink / raw)
  To: mchehab; +Cc: linux-media, linux-kernel, Jiapeng Chong

Eliminate the follow smatch warning:

drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn:
inconsistent indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/media/i2c/ov8865.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index ebdb20d..09ba13f 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -2836,8 +2836,7 @@ static int ov8865_get_selection(struct v4l2_subdev *subdev,
 	switch (sel->target) {
 	case V4L2_SEL_TGT_CROP:
 		mutex_lock(&sensor->mutex);
-			__ov8865_get_pad_crop(sensor, state, sel->pad,
-					      sel->which, &sel->r);
+		__ov8865_get_pad_crop(sensor, state, sel->pad, sel->which, &sel->r);
 		mutex_unlock(&sensor->mutex);
 		break;
 	case V4L2_SEL_TGT_NATIVE_SIZE:
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: i2c: Fix inconsistent indenting
  2021-12-02  8:39 [PATCH] media: i2c: Fix inconsistent indenting Jiapeng Chong
@ 2021-12-02  9:47 ` Daniel Scally
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Scally @ 2021-12-02  9:47 UTC (permalink / raw)
  To: Jiapeng Chong, mchehab; +Cc: linux-media, linux-kernel

Hi Jiapeng


Thanks for catching that

On 02/12/2021 08:39, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>


Reviewed-by: Daniel Scally <djrscally@gmail.com>

> ---
>  drivers/media/i2c/ov8865.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index ebdb20d..09ba13f 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -2836,8 +2836,7 @@ static int ov8865_get_selection(struct v4l2_subdev *subdev,
>  	switch (sel->target) {
>  	case V4L2_SEL_TGT_CROP:
>  		mutex_lock(&sensor->mutex);
> -			__ov8865_get_pad_crop(sensor, state, sel->pad,
> -					      sel->which, &sel->r);
> +		__ov8865_get_pad_crop(sensor, state, sel->pad, sel->which, &sel->r);
>  		mutex_unlock(&sensor->mutex);
>  		break;
>  	case V4L2_SEL_TGT_NATIVE_SIZE:

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-02  9:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02  8:39 [PATCH] media: i2c: Fix inconsistent indenting Jiapeng Chong
2021-12-02  9:47 ` Daniel Scally

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).