* [PATCH net-next] net: lan966x: Fix duplicate check in frame extraction
@ 2021-12-01 14:53 Horatiu Vultur
2021-12-02 12:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Horatiu Vultur @ 2021-12-01 14:53 UTC (permalink / raw)
To: UNGLinuxDriver, davem, kuba, dan.carpenter, netdev, linux-kernel,
kernel-janitors
Cc: Horatiu Vultur
The blamed commit generates the following smatch static checker warning:
drivers/net/ethernet/microchip/lan966x/lan966x_main.c:515 lan966x_xtr_irq_handler()
warn: duplicate check 'sz < 0' (previous on line 502)
This patch fixes this issue removing the duplicate check 'sz < 0'
Fixes: d28d6d2e37d10d ("net: lan966x: add port module support")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index e9e4dca6542d..be5e2b3a7f43 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -512,11 +512,6 @@ static irqreturn_t lan966x_xtr_irq_handler(int irq, void *args)
*buf = val;
}
- if (sz < 0) {
- err = sz;
- break;
- }
-
skb->protocol = eth_type_trans(skb, dev);
netif_rx_ni(skb);
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: lan966x: Fix duplicate check in frame extraction
2021-12-01 14:53 [PATCH net-next] net: lan966x: Fix duplicate check in frame extraction Horatiu Vultur
@ 2021-12-02 12:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-02 12:20 UTC (permalink / raw)
To: Horatiu Vultur
Cc: UNGLinuxDriver, davem, kuba, dan.carpenter, netdev, linux-kernel,
kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 1 Dec 2021 15:53:51 +0100 you wrote:
> The blamed commit generates the following smatch static checker warning:
>
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:515 lan966x_xtr_irq_handler()
> warn: duplicate check 'sz < 0' (previous on line 502)
>
> This patch fixes this issue removing the duplicate check 'sz < 0'
>
> [...]
Here is the summary with links:
- [net-next] net: lan966x: Fix duplicate check in frame extraction
https://git.kernel.org/netdev/net-next/c/a290cf692779
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-02 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 14:53 [PATCH net-next] net: lan966x: Fix duplicate check in frame extraction Horatiu Vultur
2021-12-02 12:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).