* [PATCH] KVM: arm64: Constify kvm_io_gic_ops
@ 2021-12-04 21:35 Rikard Falkeborn
2021-12-06 8:41 ` Marc Zyngier
2021-12-20 14:00 ` [irqchip: irq/irqchip-next] " irqchip-bot for Rikard Falkeborn
0 siblings, 2 replies; 3+ messages in thread
From: Rikard Falkeborn @ 2021-12-04 21:35 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Alexandru Elisei, Suzuki K Poulose
Cc: Catalin Marinas, Will Deacon, Eric Auger, linux-arm-kernel,
kvmarm, linux-kernel, Rikard Falkeborn
The only usage of kvm_io_gic_ops is to make a comparison with its
address and to pass its address to kvm_iodevice_init() which takes a
pointer to const kvm_io_device_ops as input. Make it const to allow the
compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
arch/arm64/kvm/vgic/vgic-mmio.c | 2 +-
arch/arm64/kvm/vgic/vgic-mmio.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c b/arch/arm64/kvm/vgic/vgic-mmio.c
index 48c6067fc5ec..7068da080799 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.c
+++ b/arch/arm64/kvm/vgic/vgic-mmio.c
@@ -1050,7 +1050,7 @@ static int dispatch_mmio_write(struct kvm_vcpu *vcpu, struct kvm_io_device *dev,
return 0;
}
-struct kvm_io_device_ops kvm_io_gic_ops = {
+const struct kvm_io_device_ops kvm_io_gic_ops = {
.read = dispatch_mmio_read,
.write = dispatch_mmio_write,
};
diff --git a/arch/arm64/kvm/vgic/vgic-mmio.h b/arch/arm64/kvm/vgic/vgic-mmio.h
index fefcca2b14dc..3fa696f198a3 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.h
+++ b/arch/arm64/kvm/vgic/vgic-mmio.h
@@ -34,7 +34,7 @@ struct vgic_register_region {
};
};
-extern struct kvm_io_device_ops kvm_io_gic_ops;
+extern const struct kvm_io_device_ops kvm_io_gic_ops;
#define VGIC_ACCESS_8bit 1
#define VGIC_ACCESS_32bit 2
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: Constify kvm_io_gic_ops
2021-12-04 21:35 [PATCH] KVM: arm64: Constify kvm_io_gic_ops Rikard Falkeborn
@ 2021-12-06 8:41 ` Marc Zyngier
2021-12-20 14:00 ` [irqchip: irq/irqchip-next] " irqchip-bot for Rikard Falkeborn
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2021-12-06 8:41 UTC (permalink / raw)
To: Rikard Falkeborn, Suzuki K Poulose, James Morse, Alexandru Elisei
Cc: Eric Auger, Will Deacon, kvmarm, linux-arm-kernel, linux-kernel,
Catalin Marinas
On Sat, 4 Dec 2021 22:35:18 +0100, Rikard Falkeborn wrote:
> The only usage of kvm_io_gic_ops is to make a comparison with its
> address and to pass its address to kvm_iodevice_init() which takes a
> pointer to const kvm_io_device_ops as input. Make it const to allow the
> compiler to put it in read-only memory.
Applied to next, thanks!
[1/1] KVM: arm64: Constify kvm_io_gic_ops
commit: 636dcd0204599f94680f8f87b46cef7c66034ac0
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [irqchip: irq/irqchip-next] KVM: arm64: Constify kvm_io_gic_ops
2021-12-04 21:35 [PATCH] KVM: arm64: Constify kvm_io_gic_ops Rikard Falkeborn
2021-12-06 8:41 ` Marc Zyngier
@ 2021-12-20 14:00 ` irqchip-bot for Rikard Falkeborn
1 sibling, 0 replies; 3+ messages in thread
From: irqchip-bot for Rikard Falkeborn @ 2021-12-20 14:00 UTC (permalink / raw)
To: linux-kernel; +Cc: Rikard Falkeborn, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 636dcd0204599f94680f8f87b46cef7c66034ac0
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/636dcd0204599f94680f8f87b46cef7c66034ac0
Author: Rikard Falkeborn <rikard.falkeborn@gmail.com>
AuthorDate: Sat, 04 Dec 2021 22:35:18 +01:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 06 Dec 2021 08:34:06
KVM: arm64: Constify kvm_io_gic_ops
The only usage of kvm_io_gic_ops is to make a comparison with its
address and to pass its address to kvm_iodevice_init() which takes a
pointer to const kvm_io_device_ops as input. Make it const to allow the
compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211204213518.83642-1-rikard.falkeborn@gmail.com
---
arch/arm64/kvm/vgic/vgic-mmio.c | 2 +-
arch/arm64/kvm/vgic/vgic-mmio.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c b/arch/arm64/kvm/vgic/vgic-mmio.c
index 48c6067..7068da0 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.c
+++ b/arch/arm64/kvm/vgic/vgic-mmio.c
@@ -1050,7 +1050,7 @@ static int dispatch_mmio_write(struct kvm_vcpu *vcpu, struct kvm_io_device *dev,
return 0;
}
-struct kvm_io_device_ops kvm_io_gic_ops = {
+const struct kvm_io_device_ops kvm_io_gic_ops = {
.read = dispatch_mmio_read,
.write = dispatch_mmio_write,
};
diff --git a/arch/arm64/kvm/vgic/vgic-mmio.h b/arch/arm64/kvm/vgic/vgic-mmio.h
index fefcca2..3fa696f 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.h
+++ b/arch/arm64/kvm/vgic/vgic-mmio.h
@@ -34,7 +34,7 @@ struct vgic_register_region {
};
};
-extern struct kvm_io_device_ops kvm_io_gic_ops;
+extern const struct kvm_io_device_ops kvm_io_gic_ops;
#define VGIC_ACCESS_8bit 1
#define VGIC_ACCESS_32bit 2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-20 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-04 21:35 [PATCH] KVM: arm64: Constify kvm_io_gic_ops Rikard Falkeborn
2021-12-06 8:41 ` Marc Zyngier
2021-12-20 14:00 ` [irqchip: irq/irqchip-next] " irqchip-bot for Rikard Falkeborn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).