* [PATCH] gve: fix for null pointer dereference.
@ 2021-12-05 18:33 Ameer Hamza
2021-12-05 18:38 ` [PATCH v2] " Ameer Hamza
0 siblings, 1 reply; 3+ messages in thread
From: Ameer Hamza @ 2021-12-05 18:33 UTC (permalink / raw)
To: jeroendb, csully, awogbemila, davem, kuba, bcf, willemb
Cc: netdev, linux-kernel, amhamza.mgc
Avoid passing NULL skb to __skb_put() function call if
napi_alloc_skb() returns NULL.
Addresses-Coverity: 1494144 (Dereference NULL return value)
Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
drivers/net/ethernet/google/gve/gve_utils.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/google/gve/gve_utils.c b/drivers/net/ethernet/google/gve/gve_utils.c
index 88ca49cbc1e2..f4befdb54ad4 100644
--- a/drivers/net/ethernet/google/gve/gve_utils.c
+++ b/drivers/net/ethernet/google/gve/gve_utils.c
@@ -68,6 +68,9 @@ struct sk_buff *gve_rx_copy(struct net_device *dev, struct napi_struct *napi,
set_protocol = ctx->curr_frag_cnt == ctx->expected_frag_cnt - 1;
} else {
skb = napi_alloc_skb(napi, len);
+
+ if (unlikely(!ctx->skb_head))
+ return NULL;
set_protocol = true;
}
__skb_put(skb, len);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] gve: fix for null pointer dereference.
2021-12-05 18:33 [PATCH] gve: fix for null pointer dereference Ameer Hamza
@ 2021-12-05 18:38 ` Ameer Hamza
2021-12-08 5:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: Ameer Hamza @ 2021-12-05 18:38 UTC (permalink / raw)
To: jeroendb, csully, awogbemila, davem, kuba, bcf, willemb
Cc: netdev, linux-kernel, amhamza.mgc
Avoid passing NULL skb to __skb_put() function call if
napi_alloc_skb() returns NULL.
Addresses-Coverity: 1494144 (Dereference NULL return value)
Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
Change in v2:
checking for correct skb pointer for NULL check
---
drivers/net/ethernet/google/gve/gve_utils.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/google/gve/gve_utils.c b/drivers/net/ethernet/google/gve/gve_utils.c
index 88ca49cbc1e2..d57508bc4307 100644
--- a/drivers/net/ethernet/google/gve/gve_utils.c
+++ b/drivers/net/ethernet/google/gve/gve_utils.c
@@ -68,6 +68,9 @@ struct sk_buff *gve_rx_copy(struct net_device *dev, struct napi_struct *napi,
set_protocol = ctx->curr_frag_cnt == ctx->expected_frag_cnt - 1;
} else {
skb = napi_alloc_skb(napi, len);
+
+ if (unlikely(!skb))
+ return NULL;
set_protocol = true;
}
__skb_put(skb, len);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] gve: fix for null pointer dereference.
2021-12-05 18:38 ` [PATCH v2] " Ameer Hamza
@ 2021-12-08 5:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-08 5:10 UTC (permalink / raw)
To: Ameer Hamza
Cc: jeroendb, csully, awogbemila, davem, kuba, bcf, willemb, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 5 Dec 2021 23:38:10 +0500 you wrote:
> Avoid passing NULL skb to __skb_put() function call if
> napi_alloc_skb() returns NULL.
>
> Addresses-Coverity: 1494144 (Dereference NULL return value)
>
> Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
>
> [...]
Here is the summary with links:
- [v2] gve: fix for null pointer dereference.
https://git.kernel.org/netdev/net/c/e6f60c51f043
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-08 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-05 18:33 [PATCH] gve: fix for null pointer dereference Ameer Hamza
2021-12-05 18:38 ` [PATCH v2] " Ameer Hamza
2021-12-08 5:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).