linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dmaengine: uniphier-xdmac: Fix type of address variables
@ 2021-12-14  4:42 Kunihiko Hayashi
  2022-01-03 12:19 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Kunihiko Hayashi @ 2021-12-14  4:42 UTC (permalink / raw)
  To: Vinod Koul, Masami Hiramatsu
  Cc: dmaengine, linux-arm-kernel, linux-kernel, Kunihiko Hayashi

The variables src_addr and dst_addr handle DMA addresses, so these should
be declared as dma_addr_t.

Fixes: 667b9251440b ("dmaengine: uniphier-xdmac: Add UniPhier external DMA controller driver")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/dma/uniphier-xdmac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/uniphier-xdmac.c b/drivers/dma/uniphier-xdmac.c
index d6b8a202474f..290836b7e1be 100644
--- a/drivers/dma/uniphier-xdmac.c
+++ b/drivers/dma/uniphier-xdmac.c
@@ -131,8 +131,9 @@ uniphier_xdmac_next_desc(struct uniphier_xdmac_chan *xc)
 static void uniphier_xdmac_chan_start(struct uniphier_xdmac_chan *xc,
 				      struct uniphier_xdmac_desc *xd)
 {
-	u32 src_mode, src_addr, src_width;
-	u32 dst_mode, dst_addr, dst_width;
+	u32 src_mode, src_width;
+	u32 dst_mode, dst_width;
+	dma_addr_t src_addr, dst_addr;
 	u32 val, its, tnum;
 	enum dma_slave_buswidth buswidth;
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: uniphier-xdmac: Fix type of address variables
  2021-12-14  4:42 [PATCH] dmaengine: uniphier-xdmac: Fix type of address variables Kunihiko Hayashi
@ 2022-01-03 12:19 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-01-03 12:19 UTC (permalink / raw)
  To: Kunihiko Hayashi
  Cc: Masami Hiramatsu, dmaengine, linux-arm-kernel, linux-kernel

On 14-12-21, 13:42, Kunihiko Hayashi wrote:
> The variables src_addr and dst_addr handle DMA addresses, so these should
> be declared as dma_addr_t.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-03 12:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14  4:42 [PATCH] dmaengine: uniphier-xdmac: Fix type of address variables Kunihiko Hayashi
2022-01-03 12:19 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).