* [PATCH linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment.
@ 2022-08-15 6:12 cgel.zte
2022-08-15 6:45 ` Muchun Song
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-15 6:12 UTC (permalink / raw)
To: hannes
Cc: mhocko, roman.gushchin, shakeelb, songmuchun, akpm, cgroups,
linux-mm, linux-kernel, xupanda, Zeal Robot
From: xupanda <xu.panda@zte.com.cn>
Reported-by: Zeal Robot <zealic@zte.com.cn>
Signed-off-by: xupanda <xu.panda@zte.com.cn>
Thanks-to: Yang Yang <yang.yang29@zte.com.cn>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index b69979c9ced5..4dddd8be320a 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1143,7 +1143,7 @@ static void invalidate_reclaim_iterators(struct mem_cgroup *dead_memcg)
} while ((memcg = parent_mem_cgroup(memcg)));
/*
- * When cgruop1 non-hierarchy mode is used,
+ * When cgroup1 non-hierarchy mode is used,
* parent_mem_cgroup() does not walk all the way up to the
* cgroup root (root_mem_cgroup). So we have to handle
* dead_memcg from cgroup root separately.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment.
2022-08-15 6:12 [PATCH linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment cgel.zte
@ 2022-08-15 6:45 ` Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: Muchun Song @ 2022-08-15 6:45 UTC (permalink / raw)
To: cgel.zte
Cc: Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
Muchun Song, Andrew Morton, cgroups, Linux MM, linux-kernel,
xupanda, Zeal Robot
> On Aug 15, 2022, at 14:12, cgel.zte@gmail.com wrote:
>
> From: xupanda <xu.panda@zte.com.cn>
1. Your subject seems to have redundant description.
“Fix typos in comment” vs “Fix a spelling mistake in comment"
2. It is better to clarify what you have changed here. Like:
Fix a spelling mistake on “cgruop1”.
With this:
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-15 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 6:12 [PATCH linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment cgel.zte
2022-08-15 6:45 ` Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).