* [PATCH] net/ncsi: check for error return from call to nla_put_u32
@ 2021-12-29 3:21 Jiasheng Jiang
2021-12-30 2:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2021-12-29 3:21 UTC (permalink / raw)
To: sam, davem, kuba; +Cc: netdev, linux-kernel, Jiasheng Jiang
As we can see from the comment of the nla_put() that it could return
-EMSGSIZE if the tailroom of the skb is insufficient.
Therefore, it should be better to check the return value of the
nla_put_u32 and return the error code if error accurs.
Also, there are many other functions have the same problem, and if this
patch is correct, I will commit a new version to fix all.
Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
net/ncsi/ncsi-netlink.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/ncsi/ncsi-netlink.c b/net/ncsi/ncsi-netlink.c
index bb5f1650f11c..c189b4c8a182 100644
--- a/net/ncsi/ncsi-netlink.c
+++ b/net/ncsi/ncsi-netlink.c
@@ -112,7 +112,11 @@ static int ncsi_write_package_info(struct sk_buff *skb,
pnest = nla_nest_start_noflag(skb, NCSI_PKG_ATTR);
if (!pnest)
return -ENOMEM;
- nla_put_u32(skb, NCSI_PKG_ATTR_ID, np->id);
+ rc = nla_put_u32(skb, NCSI_PKG_ATTR_ID, np->id);
+ if (rc) {
+ nla_nest_cancel(skb, pnest);
+ return rc;
+ }
if ((0x1 << np->id) == ndp->package_whitelist)
nla_put_flag(skb, NCSI_PKG_ATTR_FORCED);
cnest = nla_nest_start_noflag(skb, NCSI_PKG_ATTR_CHANNEL_LIST);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ncsi: check for error return from call to nla_put_u32
2021-12-29 3:21 [PATCH] net/ncsi: check for error return from call to nla_put_u32 Jiasheng Jiang
@ 2021-12-30 2:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-30 2:30 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: sam, davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 29 Dec 2021 11:21:18 +0800 you wrote:
> As we can see from the comment of the nla_put() that it could return
> -EMSGSIZE if the tailroom of the skb is insufficient.
> Therefore, it should be better to check the return value of the
> nla_put_u32 and return the error code if error accurs.
> Also, there are many other functions have the same problem, and if this
> patch is correct, I will commit a new version to fix all.
>
> [...]
Here is the summary with links:
- net/ncsi: check for error return from call to nla_put_u32
https://git.kernel.org/netdev/net/c/92a34ab169f9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-30 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-29 3:21 [PATCH] net/ncsi: check for error return from call to nla_put_u32 Jiasheng Jiang
2021-12-30 2:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).