* [PATCH -next] block: fix old-style declaration
@ 2022-01-07 0:52 Yang Li
2022-01-09 17:37 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-01-07 0:52 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Yang Li, Abaci Robot
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 964 bytes --]
Move the 'inline' keyword to the front of 'void'.
Remove a warning found by clang(make W=1 LLVM=1)
./include/linux/blk-mq.h:259:1: warning: ‘inline’ is not at beginning of
declaration
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
include/linux/blk-mq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index f40a05ecca4a..d319ffa59354 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -256,7 +256,7 @@ static inline unsigned short req_get_ioprio(struct request *req)
* @rq: The request to move
* @prev: The request preceding @rq in @src (NULL if @rq is the head)
*/
-static void inline rq_list_move(struct request **src, struct request **dst,
+static inline void rq_list_move(struct request **src, struct request **dst,
struct request *rq, struct request *prev)
{
if (prev)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] block: fix old-style declaration
2022-01-07 0:52 [PATCH -next] block: fix old-style declaration Yang Li
@ 2022-01-09 17:37 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-01-09 17:37 UTC (permalink / raw)
To: Yang Li; +Cc: Abaci Robot, linux-kernel, linux-block
On Fri, 7 Jan 2022 08:52:28 +0800, Yang Li wrote:
> Move the 'inline' keyword to the front of 'void'.
>
> Remove a warning found by clang(make W=1 LLVM=1)
> ./include/linux/blk-mq.h:259:1: warning: ‘inline’ is not at beginning of
> declaration
>
>
> [...]
Applied, thanks!
[1/1] block: fix old-style declaration
commit: 292c33c95defd0b814fec1fc8cd60d16556cf7b8
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-09 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 0:52 [PATCH -next] block: fix old-style declaration Yang Li
2022-01-09 17:37 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).