* [PATCH] coresight: Drop unused 'none' enum value for each component
@ 2022-02-16 9:51 Anshuman Khandual
2022-02-28 16:54 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Anshuman Khandual @ 2022-02-16 9:51 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Anshuman Khandual, Mathieu Poirier, Suzuki K Poulose, Mike Leach,
Leo Yan, coresight, linux-kernel
CORESIGHT_DEV_TYPE_NONE/CORESIGHT_DEV_SUBTYPE_XXXX_NONE values are not used
any where. Actual enumeration can start from 0. Just drop these unused enum
values.
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
drivers/hwtracing/coresight/coresight-core.c | 3 ---
include/linux/coresight.h | 5 -----
2 files changed, 8 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index 88653d1c06a4..af00dca8d1ac 100644
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -1278,9 +1278,6 @@ static struct attribute *coresight_source_attrs[] = {
ATTRIBUTE_GROUPS(coresight_source);
static struct device_type coresight_dev_type[] = {
- {
- .name = "none",
- },
{
.name = "sink",
.groups = coresight_sink_groups,
diff --git a/include/linux/coresight.h b/include/linux/coresight.h
index 93a2922b7653..9f445f09fcfe 100644
--- a/include/linux/coresight.h
+++ b/include/linux/coresight.h
@@ -36,7 +36,6 @@
extern struct bus_type coresight_bustype;
enum coresight_dev_type {
- CORESIGHT_DEV_TYPE_NONE,
CORESIGHT_DEV_TYPE_SINK,
CORESIGHT_DEV_TYPE_LINK,
CORESIGHT_DEV_TYPE_LINKSINK,
@@ -46,7 +45,6 @@ enum coresight_dev_type {
};
enum coresight_dev_subtype_sink {
- CORESIGHT_DEV_SUBTYPE_SINK_NONE,
CORESIGHT_DEV_SUBTYPE_SINK_PORT,
CORESIGHT_DEV_SUBTYPE_SINK_BUFFER,
CORESIGHT_DEV_SUBTYPE_SINK_SYSMEM,
@@ -54,21 +52,18 @@ enum coresight_dev_subtype_sink {
};
enum coresight_dev_subtype_link {
- CORESIGHT_DEV_SUBTYPE_LINK_NONE,
CORESIGHT_DEV_SUBTYPE_LINK_MERG,
CORESIGHT_DEV_SUBTYPE_LINK_SPLIT,
CORESIGHT_DEV_SUBTYPE_LINK_FIFO,
};
enum coresight_dev_subtype_source {
- CORESIGHT_DEV_SUBTYPE_SOURCE_NONE,
CORESIGHT_DEV_SUBTYPE_SOURCE_PROC,
CORESIGHT_DEV_SUBTYPE_SOURCE_BUS,
CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE,
};
enum coresight_dev_subtype_helper {
- CORESIGHT_DEV_SUBTYPE_HELPER_NONE,
CORESIGHT_DEV_SUBTYPE_HELPER_CATU,
};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] coresight: Drop unused 'none' enum value for each component
2022-02-16 9:51 [PATCH] coresight: Drop unused 'none' enum value for each component Anshuman Khandual
@ 2022-02-28 16:54 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2022-02-28 16:54 UTC (permalink / raw)
To: Anshuman Khandual
Cc: linux-arm-kernel, Suzuki K Poulose, Mike Leach, Leo Yan,
coresight, linux-kernel
Good morning,
On Wed, Feb 16, 2022 at 03:21:58PM +0530, Anshuman Khandual wrote:
> CORESIGHT_DEV_TYPE_NONE/CORESIGHT_DEV_SUBTYPE_XXXX_NONE values are not used
> any where. Actual enumeration can start from 0. Just drop these unused enum
> values.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: coresight@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 3 ---
> include/linux/coresight.h | 5 -----
> 2 files changed, 8 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 88653d1c06a4..af00dca8d1ac 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1278,9 +1278,6 @@ static struct attribute *coresight_source_attrs[] = {
> ATTRIBUTE_GROUPS(coresight_source);
>
> static struct device_type coresight_dev_type[] = {
> - {
> - .name = "none",
> - },
> {
> .name = "sink",
> .groups = coresight_sink_groups,
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 93a2922b7653..9f445f09fcfe 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -36,7 +36,6 @@
> extern struct bus_type coresight_bustype;
>
> enum coresight_dev_type {
> - CORESIGHT_DEV_TYPE_NONE,
> CORESIGHT_DEV_TYPE_SINK,
> CORESIGHT_DEV_TYPE_LINK,
> CORESIGHT_DEV_TYPE_LINKSINK,
> @@ -46,7 +45,6 @@ enum coresight_dev_type {
> };
>
> enum coresight_dev_subtype_sink {
> - CORESIGHT_DEV_SUBTYPE_SINK_NONE,
> CORESIGHT_DEV_SUBTYPE_SINK_PORT,
> CORESIGHT_DEV_SUBTYPE_SINK_BUFFER,
> CORESIGHT_DEV_SUBTYPE_SINK_SYSMEM,
> @@ -54,21 +52,18 @@ enum coresight_dev_subtype_sink {
> };
>
> enum coresight_dev_subtype_link {
> - CORESIGHT_DEV_SUBTYPE_LINK_NONE,
> CORESIGHT_DEV_SUBTYPE_LINK_MERG,
> CORESIGHT_DEV_SUBTYPE_LINK_SPLIT,
> CORESIGHT_DEV_SUBTYPE_LINK_FIFO,
> };
>
> enum coresight_dev_subtype_source {
> - CORESIGHT_DEV_SUBTYPE_SOURCE_NONE,
> CORESIGHT_DEV_SUBTYPE_SOURCE_PROC,
> CORESIGHT_DEV_SUBTYPE_SOURCE_BUS,
> CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE,
> };
>
> enum coresight_dev_subtype_helper {
> - CORESIGHT_DEV_SUBTYPE_HELPER_NONE,
> CORESIGHT_DEV_SUBTYPE_HELPER_CATU,
> };
These have never been used in the 7 years the subsystem has existed and I don't
see in what kind of situation they could be...
I have applied this patch.
Thanks,
Mathieu
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-28 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 9:51 [PATCH] coresight: Drop unused 'none' enum value for each component Anshuman Khandual
2022-02-28 16:54 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).