* [PATCH] net: wireless: marvell: use time_is_before_jiffies() instead of open coding it
@ 2022-02-28 3:14 Qing Wang
2022-03-10 16:11 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2022-02-28 3:14 UTC (permalink / raw)
To: Amitkumar Karwar, Ganapathi Bhat, Sharvari Harisangam,
Xinming Hu, Kalle Valo, David S. Miller, Jakub Kicinski,
Lennert Buytenhek, linux-wireless, netdev, linux-kernel
Cc: Wang Qing
From: Wang Qing <wangqing@vivo.com>
Use the helper function time_is_{before,after}_jiffies() to improve
code readability.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/net/wireless/marvell/mwifiex/tdls.c | 4 ++--
drivers/net/wireless/marvell/mwl8k.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c
index 97bb87c..aa77fc3
--- a/drivers/net/wireless/marvell/mwifiex/tdls.c
+++ b/drivers/net/wireless/marvell/mwifiex/tdls.c
@@ -1436,8 +1436,8 @@ void mwifiex_check_auto_tdls(struct timer_list *t)
spin_lock_bh(&priv->auto_tdls_lock);
list_for_each_entry(tdls_peer, &priv->auto_tdls_list, list) {
- if ((jiffies - tdls_peer->rssi_jiffies) >
- (MWIFIEX_AUTO_TDLS_IDLE_TIME * HZ)) {
+ if (time_is_before_jiffies(tdls_peer->rssi_jiffies +
+ (MWIFIEX_AUTO_TDLS_IDLE_TIME * HZ))) {
tdls_peer->rssi = 0;
tdls_peer->do_discover = true;
priv->check_tdls_tx = true;
diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
index 864a2ba..9efe825
--- a/drivers/net/wireless/marvell/mwl8k.c
+++ b/drivers/net/wireless/marvell/mwl8k.c
@@ -24,6 +24,7 @@
#include <linux/moduleparam.h>
#include <linux/firmware.h>
#include <linux/workqueue.h>
+#include <linux/jiffies.h>
#define MWL8K_DESC "Marvell TOPDOG(R) 802.11 Wireless Network Driver"
#define MWL8K_NAME KBUILD_MODNAME
@@ -1880,7 +1881,7 @@ static inline void mwl8k_tx_count_packet(struct ieee80211_sta *sta, u8 tid)
* packets ever exceeds the ampdu_min_traffic threshold, we will allow
* an ampdu stream to be started.
*/
- if (jiffies - tx_stats->start_time > HZ) {
+ if (time_is_before_jiffies(tx_stats->start_time + HZ)) {
tx_stats->pkts = 0;
tx_stats->start_time = 0;
} else
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: wireless: marvell: use time_is_before_jiffies() instead of open coding it
2022-02-28 3:14 [PATCH] net: wireless: marvell: use time_is_before_jiffies() instead of open coding it Qing Wang
@ 2022-03-10 16:11 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-03-10 16:11 UTC (permalink / raw)
To: Qing Wang
Cc: Amitkumar Karwar, Ganapathi Bhat, Sharvari Harisangam,
Xinming Hu, Kalle Valo, David S. Miller, Jakub Kicinski,
Lennert Buytenhek, linux-wireless, netdev, linux-kernel,
Wang Qing
Qing Wang <wangqing@vivo.com> wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
One patch per driver, please. One for mwifiex and another for mwl8k.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/1646018045-61229-1-git-send-email-wangqing@vivo.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-10 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 3:14 [PATCH] net: wireless: marvell: use time_is_before_jiffies() instead of open coding it Qing Wang
2022-03-10 16:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).