* [PATCH] pstore: Add prefix to ECC messages
@ 2022-03-01 14:49 Vincent Whitchurch
2022-03-01 18:44 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Whitchurch @ 2022-03-01 14:49 UTC (permalink / raw)
To: Kees Cook, Anton Vorontsov, Colin Cross, Tony Luck
Cc: kernel, Vincent Whitchurch, linux-kernel
The "No errors detected" message from the ECC code is shown at the end
of the pstore log and can be confusing or misleading, especially since
it usually appears just after a kernel crash log which normally means
quite the opposite of "no errors". Prefix the message to clarify that
this message is only about ECC-detected errors.
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
fs/pstore/ram_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index fe5305028c6e..a89e33719fcf 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -263,10 +263,10 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,
if (prz->corrected_bytes || prz->bad_blocks)
ret = snprintf(str, len, ""
- "\n%d Corrected bytes, %d unrecoverable blocks\n",
+ "\nECC: %d Corrected bytes, %d unrecoverable blocks\n",
prz->corrected_bytes, prz->bad_blocks);
else
- ret = snprintf(str, len, "\nNo errors detected\n");
+ ret = snprintf(str, len, "\nECC: No errors detected\n");
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pstore: Add prefix to ECC messages
2022-03-01 14:49 [PATCH] pstore: Add prefix to ECC messages Vincent Whitchurch
@ 2022-03-01 18:44 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2022-03-01 18:44 UTC (permalink / raw)
To: Anton Vorontsov, Tony Luck, Colin Cross, Vincent Whitchurch
Cc: Kees Cook, kernel, linux-kernel
On Tue, 1 Mar 2022 15:49:32 +0100, Vincent Whitchurch wrote:
> The "No errors detected" message from the ECC code is shown at the end
> of the pstore log and can be confusing or misleading, especially since
> it usually appears just after a kernel crash log which normally means
> quite the opposite of "no errors". Prefix the message to clarify that
> this message is only about ECC-detected errors.
>
>
> [...]
Excellent point. :)
Applied to for-next/pstore, thanks!
[1/1] pstore: Add prefix to ECC messages
https://git.kernel.org/kees/c/023bbde3db41
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-01 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 14:49 [PATCH] pstore: Add prefix to ECC messages Vincent Whitchurch
2022-03-01 18:44 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).