* [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
@ 2022-03-01 11:23 Wan Jiabing
2022-03-01 13:02 ` Simon Horman
2022-03-02 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2022-03-01 11:23 UTC (permalink / raw)
To: Simon Horman, Jakub Kicinski, David S. Miller, Baowen Zheng,
Louis Peens, Jianbo Liu, Wan Jiabing, Peng Zhang, oss-drivers,
netdev, linux-kernel
Cc: kael_w
Fix the following coccicheck warning:
./drivers/net/ethernet/netronome/nfp/flower/qos_conf.c:750:7-55: WARNING
avoid newline at end of message in NL_SET_ERR_MSG_MOD
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/net/ethernet/netronome/nfp/flower/qos_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c b/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c
index cd3fdb9f953b..3206ba83b1aa 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c
@@ -747,7 +747,7 @@ nfp_act_remove_actions(struct nfp_app *app, struct flow_offload_action *fl_act,
meter_entry = nfp_flower_search_meter_entry(app, meter_id);
if (!meter_entry) {
NL_SET_ERR_MSG_MOD(extack,
- "no meter entry when delete the action index.\n");
+ "no meter entry when delete the action index.");
return -ENOENT;
}
pps = !meter_entry->bps;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
2022-03-01 11:23 [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD Wan Jiabing
@ 2022-03-01 13:02 ` Simon Horman
2022-03-02 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2022-03-01 13:02 UTC (permalink / raw)
To: Wan Jiabing
Cc: Jakub Kicinski, David S. Miller, Baowen Zheng, Louis Peens,
Jianbo Liu, Peng Zhang, oss-drivers, netdev, linux-kernel,
kael_w
On Tue, Mar 01, 2022 at 07:23:54PM +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/netronome/nfp/flower/qos_conf.c:750:7-55: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Thanks Wan Jiabing,
much appreciated.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
2022-03-01 11:23 [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD Wan Jiabing
2022-03-01 13:02 ` Simon Horman
@ 2022-03-02 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-02 2:00 UTC (permalink / raw)
To: Wan Jiabing
Cc: simon.horman, kuba, davem, baowen.zheng, louis.peens, jianbol,
peng.zhang, oss-drivers, netdev, linux-kernel, kael_w
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 1 Mar 2022 19:23:54 +0800 you wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/netronome/nfp/flower/qos_conf.c:750:7-55: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/qos_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
https://git.kernel.org/netdev/net-next/c/323d51cac6a1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-02 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 11:23 [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD Wan Jiabing
2022-03-01 13:02 ` Simon Horman
2022-03-02 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).