* [PATCH v2] net: marvell: Use min() instead of doing it manually
@ 2022-03-02 6:48 Haowen Bai
2022-03-02 11:06 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Haowen Bai @ 2022-03-02 6:48 UTC (permalink / raw)
To: sebastian.hesselbarth, davem, kuba; +Cc: netdev, linux-kernel, Haowen Bai
Fix following coccicheck warning:
drivers/net/ethernet/marvell/mv643xx_eth.c:1664:35-36: WARNING opportunity for min()
Signed-off-by: Haowen Bai <baihaowen88@gmail.com>
---
drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index 143ca8b..e3e79cf 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -1661,7 +1661,7 @@ mv643xx_eth_set_ringparam(struct net_device *dev, struct ethtool_ringparam *er,
if (er->rx_mini_pending || er->rx_jumbo_pending)
return -EINVAL;
- mp->rx_ring_size = er->rx_pending < 4096 ? er->rx_pending : 4096;
+ mp->rx_ring_size = min(er->rx_pending, (unsigned)4096);
mp->tx_ring_size = clamp_t(unsigned int, er->tx_pending,
MV643XX_MAX_SKB_DESCS * 2, 4096);
if (mp->tx_ring_size != er->tx_pending)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: marvell: Use min() instead of doing it manually
2022-03-02 6:48 [PATCH v2] net: marvell: Use min() instead of doing it manually Haowen Bai
@ 2022-03-02 11:06 ` Heiner Kallweit
2022-03-03 1:38 ` lotte bai
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2022-03-02 11:06 UTC (permalink / raw)
To: Haowen Bai, sebastian.hesselbarth, davem, kuba; +Cc: netdev, linux-kernel
On 02.03.2022 07:48, Haowen Bai wrote:
> Fix following coccicheck warning:
> drivers/net/ethernet/marvell/mv643xx_eth.c:1664:35-36: WARNING opportunity for min()
>
> Signed-off-by: Haowen Bai <baihaowen88@gmail.com>
> ---
> drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index 143ca8b..e3e79cf 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -1661,7 +1661,7 @@ mv643xx_eth_set_ringparam(struct net_device *dev, struct ethtool_ringparam *er,
> if (er->rx_mini_pending || er->rx_jumbo_pending)
> return -EINVAL;
>
> - mp->rx_ring_size = er->rx_pending < 4096 ? er->rx_pending : 4096;
> + mp->rx_ring_size = min(er->rx_pending, (unsigned)4096);
Don't just use unsigned w/o int. Why not simply marking the constant as unsigned: 4096U ?
And again: You should at least compile-test it.
> mp->tx_ring_size = clamp_t(unsigned int, er->tx_pending,
> MV643XX_MAX_SKB_DESCS * 2, 4096);
> if (mp->tx_ring_size != er->tx_pending)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: marvell: Use min() instead of doing it manually
2022-03-02 11:06 ` Heiner Kallweit
@ 2022-03-03 1:38 ` lotte bai
0 siblings, 0 replies; 3+ messages in thread
From: lotte bai @ 2022-03-03 1:38 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: sebastian.hesselbarth, davem, kuba, netdev, linux-kernel
Yes, I have compiled at local, either unsigned and U is pass. Thank
you for your kindly reminder.
Heiner Kallweit <hkallweit1@gmail.com> 于2022年3月2日周三 19:06写道：
>
> On 02.03.2022 07:48, Haowen Bai wrote:
> > Fix following coccicheck warning:
> > drivers/net/ethernet/marvell/mv643xx_eth.c:1664:35-36: WARNING opportunity for min()
> >
> > Signed-off-by: Haowen Bai <baihaowen88@gmail.com>
> > ---
> > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> > index 143ca8b..e3e79cf 100644
> > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> > @@ -1661,7 +1661,7 @@ mv643xx_eth_set_ringparam(struct net_device *dev, struct ethtool_ringparam *er,
> > if (er->rx_mini_pending || er->rx_jumbo_pending)
> > return -EINVAL;
> >
> > - mp->rx_ring_size = er->rx_pending < 4096 ? er->rx_pending : 4096;
> > + mp->rx_ring_size = min(er->rx_pending, (unsigned)4096);
>
> Don't just use unsigned w/o int. Why not simply marking the constant as unsigned: 4096U ?
> And again: You should at least compile-test it.
>
> > mp->tx_ring_size = clamp_t(unsigned int, er->tx_pending,
> > MV643XX_MAX_SKB_DESCS * 2, 4096);
> > if (mp->tx_ring_size != er->tx_pending)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-03 1:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 6:48 [PATCH v2] net: marvell: Use min() instead of doing it manually Haowen Bai
2022-03-02 11:06 ` Heiner Kallweit
2022-03-03 1:38 ` lotte bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).