linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] x86/hyperv: Output host build info as normal Windows version number
@ 2022-03-08 19:22 Michael Kelley
  2022-03-08 20:46 ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2022-03-08 19:22 UTC (permalink / raw)
  To: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, dave.hansen,
	x86, hpa, linux-kernel, linux-hyperv
  Cc: mikelley

Hyper-V provides host version number information that is output in
text form by a Linux guest when it boots. For whatever reason, the
formatting has historically been non-standard. Change it to output
in normal Windows version format for better readability.

Similar code for ARM64 guests already outputs in normal Windows
version format.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
 arch/x86/kernel/cpu/mshyperv.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 5a99f99..6c4b6c6 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -309,10 +309,10 @@ static void __init ms_hyperv_init_platform(void)
 		hv_host_info_ecx = cpuid_ecx(HYPERV_CPUID_VERSION);
 		hv_host_info_edx = cpuid_edx(HYPERV_CPUID_VERSION);
 
-		pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n",
-			hv_host_info_eax, hv_host_info_ebx >> 16,
-			hv_host_info_ebx & 0xFFFF, hv_host_info_ecx,
-			hv_host_info_edx >> 24, hv_host_info_edx & 0xFFFFFF);
+		pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
+			hv_host_info_ebx >> 16, hv_host_info_ebx & 0xFFFF,
+			hv_host_info_eax, hv_host_info_edx & 0xFFFFFF,
+			hv_host_info_ecx, hv_host_info_edx >> 24);
 	}
 
 	if (ms_hyperv.features & HV_ACCESS_FREQUENCY_MSRS &&
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] x86/hyperv: Output host build info as normal Windows version number
  2022-03-08 19:22 [PATCH 1/1] x86/hyperv: Output host build info as normal Windows version number Michael Kelley
@ 2022-03-08 20:46 ` Wei Liu
  2022-03-09  9:13   ` Vitaly Kuznetsov
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2022-03-08 20:46 UTC (permalink / raw)
  To: Michael Kelley
  Cc: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, dave.hansen,
	x86, hpa, linux-kernel, linux-hyperv, vkuznets

(Cc Vitaly)

On Tue, Mar 08, 2022 at 11:22:44AM -0800, Michael Kelley wrote:
> Hyper-V provides host version number information that is output in
> text form by a Linux guest when it boots. For whatever reason, the
> formatting has historically been non-standard. Change it to output
> in normal Windows version format for better readability.
> 
> Similar code for ARM64 guests already outputs in normal Windows
> version format.
> 
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>

Applied to hyperv-next. Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] x86/hyperv: Output host build info as normal Windows version number
  2022-03-08 20:46 ` Wei Liu
@ 2022-03-09  9:13   ` Vitaly Kuznetsov
  0 siblings, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2022-03-09  9:13 UTC (permalink / raw)
  To: Wei Liu, Michael Kelley
  Cc: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, dave.hansen,
	x86, hpa, linux-kernel, linux-hyperv

Wei Liu <wei.liu@kernel.org> writes:

> (Cc Vitaly)
>
> On Tue, Mar 08, 2022 at 11:22:44AM -0800, Michael Kelley wrote:
>> Hyper-V provides host version number information that is output in
>> text form by a Linux guest when it boots. For whatever reason, the
>> formatting has historically been non-standard. Change it to output
>> in normal Windows version format for better readability.
>> 
>> Similar code for ARM64 guests already outputs in normal Windows
>> version format.
>> 
>> Signed-off-by: Michael Kelley <mikelley@microsoft.com>

Works for me, thanks!

>
> Applied to hyperv-next. Thanks.

-- 
Vitaly


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-09  9:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 19:22 [PATCH 1/1] x86/hyperv: Output host build info as normal Windows version number Michael Kelley
2022-03-08 20:46 ` Wei Liu
2022-03-09  9:13   ` Vitaly Kuznetsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).