* [PATCH] macintosh: adb: Fix warning comparing pointer to 0
@ 2022-03-17 2:35 Haowen Bai
2022-11-30 9:23 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-17 2:35 UTC (permalink / raw)
To: benh, masahiroy, adobriyan; +Cc: linuxppc-dev, linux-kernel, Haowen Bai
Avoid pointer type value compared with 0 to make code clear.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/macintosh/adb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c
index 73b3961..996f310 100644
--- a/drivers/macintosh/adb.c
+++ b/drivers/macintosh/adb.c
@@ -478,7 +478,7 @@ adb_register(int default_id, int handler_id, struct adb_ids *ids,
if ((adb_handler[i].original_address == default_id) &&
(!handler_id || (handler_id == adb_handler[i].handler_id) ||
try_handler_change(i, handler_id))) {
- if (adb_handler[i].handler != 0) {
+ if (adb_handler[i].handler) {
pr_err("Two handlers for ADB device %d\n",
default_id);
continue;
@@ -673,7 +673,7 @@ static int adb_open(struct inode *inode, struct file *file)
goto out;
}
state = kmalloc(sizeof(struct adbdev_state), GFP_KERNEL);
- if (state == 0) {
+ if (!state) {
ret = -ENOMEM;
goto out;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] macintosh: adb: Fix warning comparing pointer to 0
2022-03-17 2:35 [PATCH] macintosh: adb: Fix warning comparing pointer to 0 Haowen Bai
@ 2022-11-30 9:23 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-11-30 9:23 UTC (permalink / raw)
To: Haowen Bai, masahiroy, benh, adobriyan; +Cc: linux-kernel, linuxppc-dev
On Thu, 17 Mar 2022 10:35:54 +0800, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
>
>
Applied to powerpc/next.
[1/1] macintosh: adb: Fix warning comparing pointer to 0
https://git.kernel.org/powerpc/c/2f59562c140d3119328f869126e8e593a99a392f
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-30 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 2:35 [PATCH] macintosh: adb: Fix warning comparing pointer to 0 Haowen Bai
2022-11-30 9:23 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).