From: Haowen Bai <baihaowen@meizu.com>
To: <sudeep.holla@arm.com>, <cristian.marussi@arm.com>,
<ardb@kernel.org>, <gregkh@linuxfoundation.org>
Cc: <bjorn.andersson@linaro.org>, <linux-kernel@vger.kernel.org>,
Haowen Bai <baihaowen@meizu.com>
Subject: [PATCH] firmware: edd: Remove redundant condition
Date: Thu, 17 Mar 2022 18:05:20 +0800 [thread overview]
Message-ID: <1647511520-26455-1-git-send-email-baihaowen@meizu.com> (raw)
The logic !A || A && B is equivalent to !A || B. so we have
to make code clear.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/firmware/edd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 69353dd..5cc2389 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev)
int i;
for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
- if (!attr->test ||
- (attr->test && attr->test(edev)))
+ if (!attr->test || attr->test(edev))
error = sysfs_create_file(&edev->kobj,&attr->attr);
}
--
2.7.4
next reply other threads:[~2022-03-17 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 10:05 Haowen Bai [this message]
2022-03-18 13:15 ` [PATCH] firmware: edd: Remove redundant condition Greg KH
[not found] <tjhedku0cwqypq8pujvusn6i.1647642604045@email.android.com>
2022-04-20 17:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1647511520-26455-1-git-send-email-baihaowen@meizu.com \
--to=baihaowen@meizu.com \
--cc=ardb@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cristian.marussi@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).