From: Greg KH <gregkh@linuxfoundation.org>
To: 白浩文 <baihaowen@meizu.com>
Cc: "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"cristian.marussi@arm.com" <cristian.marussi@arm.com>,
"ardb@kernel.org" <ardb@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: edd: Remove redundant condition
Date: Wed, 20 Apr 2022 19:31:45 +0200 [thread overview]
Message-ID: <YmBDgRYGdcjz3ppn@kroah.com> (raw)
In-Reply-To: <tjhedku0cwqypq8pujvusn6i.1647642604045@email.android.com>
On Fri, Mar 18, 2022 at 10:33:12PM +0000, 白浩文 wrote:
> Dear Greg KH
>
> But the logic here is:
> (!A || (A && B))
> not:
> (!A || A && B)
>
> as you write
>
> No, what I wrote is
>
> the logic here is:
> (!A || (A && B))
> Is the same:
> (!A || B)
That is not what your changelog text says, and I quote:
> > The logic !A || A && B is equivalent to !A || B. so we have
> > to make code clear.
(note, top-posting is horrid and is why we do not do this, please fix
this in the future.)
So can you please fix up your changelog text to be correct and resend
it?
thanks,
greg k-h
next parent reply other threads:[~2022-04-20 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tjhedku0cwqypq8pujvusn6i.1647642604045@email.android.com>
2022-04-20 17:31 ` Greg KH [this message]
2022-04-21 1:40 ` [PATCH V2] firmware: edd: Remove redundant condition Haowen Bai
2022-04-21 1:43 ` Haowen Bai
2022-03-17 10:05 [PATCH] " Haowen Bai
2022-03-18 13:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmBDgRYGdcjz3ppn@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=baihaowen@meizu.com \
--cc=bjorn.andersson@linaro.org \
--cc=cristian.marussi@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).