[PATCH V3 0/2] Add reset entries for SDCC controllers

[PATCH V3 0/2] Add reset entries for SDCC controllers

[Shaik Sajida Bhanu]

Changes since V2:
	- Updated commit subject and comments in dtsi file.
	- Added resets entry in sdhci-msm dt-bindings.

Changes since V1:
	- Updated commit message, subject and comments in dtsi file as
	  suggested by Krzysztof Kozlowski.

Shaik Sajida Bhanu (2):
  dt-bindings: mmc: sdhci-msm: Add gcc resets strings
  arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers

 Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
 arch/arm64/boot/dts/qcom/sc7280.dtsi                | 8 ++++++++
 2 files changed, 12 insertions(+)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation

[PATCH V3 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings

[Shaik Sajida Bhanu]

Add gcc hardware reset supported strings for qcom-sdhci controller.

Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
index 6216ed7..f180111 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
@@ -62,6 +62,10 @@ Required properties:
 - qcom,dll-config: Chipset and Platform specific value. Use this field to
 	specify the DLL_CONFIG register value as per Hardware Programming Guide.
 
+- resets: Phandle and reset specifier for the device's reset.
+- reset-names: List of reset signal name strings sorted in the same order as
+	       the resets property.
+
 Optional Properties:
 * Following bus parameters are required for interconnect bandwidth scaling:
 - interconnects: Pairs of phandles and interconnect provider specifier
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation

[PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers

[Shaik Sajida Bhanu]

Add gcc hardware reset entries for eMMC and SD card.

Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index c07765d..cd50ea3 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -881,6 +881,10 @@
 			mmc-hs400-1_8v;
 			mmc-hs400-enhanced-strobe;
 
+			/* gcc hardware reset entry for eMMC */
+			resets = <&gcc GCC_SDCC1_BCR>;
+			reset-names = "core_reset";
+
 			sdhc1_opp_table: opp-table {
 				compatible = "operating-points-v2";
 
@@ -2686,6 +2690,10 @@
 
 			qcom,dll-config = <0x0007642c>;
 
+			/* gcc hardware reset entry for SD card */
+			resets = <&gcc GCC_SDCC2_BCR>;
+			reset-names = "core_reset";
+
 			sdhc2_opp_table: opp-table {
 				compatible = "operating-points-v2";
 
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH V3 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings

[Krzysztof Kozlowski]

On 17/03/2022 16:49, Shaik Sajida Bhanu wrote:
> Add gcc hardware reset supported strings for qcom-sdhci controller.
> 
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 6216ed7..f180111 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -62,6 +62,10 @@ Required properties:
>  - qcom,dll-config: Chipset and Platform specific value. Use this field to
>  	specify the DLL_CONFIG register value as per Hardware Programming Guide.
>  
> +- resets: Phandle and reset specifier for the device's reset.
> +- reset-names: List of reset signal name strings sorted in the same order as
> +	       the resets property.

Please list the actual names used in reset-names.


Best regards,
Krzysztof

Re: [PATCH V3 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings

[Sajida Bhanu (Temp)]

On 3/18/2022 6:20 PM, Krzysztof Kozlowski wrote:
> On 17/03/2022 16:49, Shaik Sajida Bhanu wrote:
>> Add gcc hardware reset supported strings for qcom-sdhci controller.
>>
>> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> index 6216ed7..f180111 100644
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> @@ -62,6 +62,10 @@ Required properties:
>>   - qcom,dll-config: Chipset and Platform specific value. Use this field to
>>   	specify the DLL_CONFIG register value as per Hardware Programming Guide.
>>   
>> +- resets: Phandle and reset specifier for the device's reset.
>> +- reset-names: List of reset signal name strings sorted in the same order as
>> +	       the resets property.
> Please list the actual names used in reset-names.
Sure Thanks for the review.
>
> Best regards,
> Krzysztof

Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers

[Stephen Boyd]

Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25)
> Add gcc hardware reset entries for eMMC and SD card.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index c07765d..cd50ea3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -881,6 +881,10 @@
>                         mmc-hs400-1_8v;
>                         mmc-hs400-enhanced-strobe;
>
> +                       /* gcc hardware reset entry for eMMC */

Please don't add this worthless comment.

> +                       resets = <&gcc GCC_SDCC1_BCR>;
> +                       reset-names = "core_reset";

A "_reset" postfix is redundant. In fact, reset-names shouldn't even be
required.

> +
>                         sdhc1_opp_table: opp-table {
>                                 compatible = "operating-points-v2";
>
> @@ -2686,6 +2690,10 @@
>
>                         qcom,dll-config = <0x0007642c>;
>
> +                       /* gcc hardware reset entry for SD card */

Please don't add this worthless comment.

> +                       resets = <&gcc GCC_SDCC2_BCR>;
> +                       reset-names = "core_reset";
> +
>                         sdhc2_opp_table: opp-table {
>                                 compatible = "operating-points-v2";
>

Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers

[Sajida Bhanu (Temp)]

Hi,

Thanks for the review.

Please find the inline comments.

Thanks,
Sajida

On 4/2/2022 3:39 AM, Stephen Boyd wrote:
> Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25)
>> Add gcc hardware reset entries for eMMC and SD card.
>>
>> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index c07765d..cd50ea3 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -881,6 +881,10 @@
>>                          mmc-hs400-1_8v;
>>                          mmc-hs400-enhanced-strobe;
>>
>> +                       /* gcc hardware reset entry for eMMC */
> Please don't add this worthless comment.
>
>> +                       resets = <&gcc GCC_SDCC1_BCR>;
>> +                       reset-names = "core_reset";
> A "_reset" postfix is redundant. In fact, reset-names shouldn't even be
> required.
Ok
>> +
>>                          sdhc1_opp_table: opp-table {
>>                                  compatible = "operating-points-v2";
>>
>> @@ -2686,6 +2690,10 @@
>>
>>                          qcom,dll-config = <0x0007642c>;
>>
>> +                       /* gcc hardware reset entry for SD card */
> Please don't add this worthless comment.
Sure will remove the comment.
>> +                       resets = <&gcc GCC_SDCC2_BCR>;
>> +                       reset-names = "core_reset";
>> +
>>                          sdhc2_opp_table: opp-table {
>>                                  compatible = "operating-points-v2";
>>

Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers

[Ulf Hansson]

+ Bhupesh Sharma


On Thu, 17 Mar 2022 at 16:49, Shaik Sajida Bhanu
<quic_c_sbhanu@quicinc.com> wrote:
>
> Add gcc hardware reset entries for eMMC and SD card.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>

As I just replied to Bhupesh Sharma, it would be nice to get all the
mmc DT bindings converted to the yaml format.

Would you mind having a look at doing the conversion first, thus prior
to extending the existing text-based docs?

Kind regards
Uffe

> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index c07765d..cd50ea3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -881,6 +881,10 @@
>                         mmc-hs400-1_8v;
>                         mmc-hs400-enhanced-strobe;
>
> +                       /* gcc hardware reset entry for eMMC */
> +                       resets = <&gcc GCC_SDCC1_BCR>;
> +                       reset-names = "core_reset";
> +
>                         sdhc1_opp_table: opp-table {
>                                 compatible = "operating-points-v2";
>
> @@ -2686,6 +2690,10 @@
>
>                         qcom,dll-config = <0x0007642c>;
>
> +                       /* gcc hardware reset entry for SD card */
> +                       resets = <&gcc GCC_SDCC2_BCR>;
> +                       reset-names = "core_reset";
> +
>                         sdhc2_opp_table: opp-table {
>                                 compatible = "operating-points-v2";
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>