* [PATCH v1] clk: socfpga: Fix a potential memory leak for kzalloc()
@ 2022-03-24 8:05 QintaoShen
0 siblings, 0 replies; only message in thread
From: QintaoShen @ 2022-03-24 8:05 UTC (permalink / raw)
To: dinguyen; +Cc: linux-kernel, QintaoShen
kfree() is missing on an error path to free the memory allocated by kzalloc().
Signed-off-by: QintaoShen <unSimple1993@163.com>
---
drivers/clk/socfpga/clk-gate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c
index 53d6e3e..0ca5e00 100644
--- a/drivers/clk/socfpga/clk-gate.c
+++ b/drivers/clk/socfpga/clk-gate.c
@@ -188,8 +188,10 @@ void __init socfpga_gate_init(struct device_node *node)
return;
ops = kmemdup(&gateclk_ops, sizeof(gateclk_ops), GFP_KERNEL);
- if (WARN_ON(!ops))
+ if (WARN_ON(!ops)) {
+ kfree(socfpga_clk);
return;
+ }
rc = of_property_read_u32_array(node, "clk-gate", clk_gate, 2);
if (rc)
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-24 8:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 8:05 [PATCH v1] clk: socfpga: Fix a potential memory leak for kzalloc() QintaoShen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).