* [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl
@ 2022-03-24 9:07 Haowen Bai
2022-03-24 13:27 ` Patrik Jakobsson
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-24 9:07 UTC (permalink / raw)
To: patrik.r.jakobsson, airlied, daniel; +Cc: dri-devel, linux-kernel, Haowen Bai
WARNING: Statements should start on a tabstop
WARNING: Missing a blank line after declarations
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/gpu/drm/gma500/mid_bios.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c
index 7e76790..71942c2 100644
--- a/drivers/gpu/drm/gma500/mid_bios.c
+++ b/drivers/gpu/drm/gma500/mid_bios.c
@@ -50,8 +50,8 @@ static void mid_get_fuse_settings(struct drm_device *dev)
DRM_INFO("internal display is %s\n",
dev_priv->iLVDS_enable ? "LVDS display" : "MIPI display");
- /* Prevent runtime suspend at start*/
- if (dev_priv->iLVDS_enable) {
+ /* Prevent runtime suspend at start*/
+ if (dev_priv->iLVDS_enable) {
dev_priv->is_lvds_on = true;
dev_priv->is_mipi_on = false;
} else {
@@ -325,6 +325,7 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv)
int mid_chip_setup(struct drm_device *dev)
{
struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
+
mid_get_fuse_settings(dev);
mid_get_vbt_data(dev_priv);
mid_get_pci_revID(dev_priv);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl
2022-03-24 9:07 [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl Haowen Bai
@ 2022-03-24 13:27 ` Patrik Jakobsson
0 siblings, 0 replies; 2+ messages in thread
From: Patrik Jakobsson @ 2022-03-24 13:27 UTC (permalink / raw)
To: Haowen Bai; +Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
On Thu, Mar 24, 2022 at 10:16 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> WARNING: Statements should start on a tabstop
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Hi, thanks for the patch.
> ---
> drivers/gpu/drm/gma500/mid_bios.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c
> index 7e76790..71942c2 100644
> --- a/drivers/gpu/drm/gma500/mid_bios.c
> +++ b/drivers/gpu/drm/gma500/mid_bios.c
> @@ -50,8 +50,8 @@ static void mid_get_fuse_settings(struct drm_device *dev)
> DRM_INFO("internal display is %s\n",
> dev_priv->iLVDS_enable ? "LVDS display" : "MIPI display");
>
> - /* Prevent runtime suspend at start*/
> - if (dev_priv->iLVDS_enable) {
> + /* Prevent runtime suspend at start*/
There should also be a space between "start" and "*/" at the end of the line
-Patrik
> + if (dev_priv->iLVDS_enable) {
> dev_priv->is_lvds_on = true;
> dev_priv->is_mipi_on = false;
> } else {
> @@ -325,6 +325,7 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv)
> int mid_chip_setup(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
> +
> mid_get_fuse_settings(dev);
> mid_get_vbt_data(dev_priv);
> mid_get_pci_revID(dev_priv);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-24 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 9:07 [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl Haowen Bai
2022-03-24 13:27 ` Patrik Jakobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).