* [PATCH net v2] net: dsa: felix: suppress -EPROBE_DEFER errors
@ 2022-04-08 10:15 Michael Walle
2022-04-08 12:46 ` Vladimir Oltean
2022-04-09 3:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2022-04-08 10:15 UTC (permalink / raw)
To: Vladimir Oltean, Claudiu Manoil, Alexandre Belloni, Andrew Lunn,
Vivien Didelot, Florian Fainelli, David S . Miller,
Jakub Kicinski, Paolo Abeni
Cc: UNGLinuxDriver, netdev, linux-kernel, Michael Walle
The DSA master might not have been probed yet in which case the probe of
the felix switch fails with -EPROBE_DEFER:
[ 4.435305] mscc_felix 0000:00:00.5: Failed to register DSA switch: -517
It is not an error. Use dev_err_probe() to demote this particular error
to a debug message.
Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
Signed-off-by: Michael Walle <michael@walle.cc>
---
changes since v1:
- add Fixes tag and thus use net instead of net-next
- just replace this particular dev_err() with dev_err_probed()
- reword commit message
drivers/net/dsa/ocelot/felix_vsc9959.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 8d382b27e625..52a8566071ed 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -2316,7 +2316,7 @@ static int felix_pci_probe(struct pci_dev *pdev,
err = dsa_register_switch(ds);
if (err) {
- dev_err(&pdev->dev, "Failed to register DSA switch: %d\n", err);
+ dev_err_probe(&pdev->dev, err, "Failed to register DSA switch\n");
goto err_register_ds;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] net: dsa: felix: suppress -EPROBE_DEFER errors
2022-04-08 10:15 [PATCH net v2] net: dsa: felix: suppress -EPROBE_DEFER errors Michael Walle
@ 2022-04-08 12:46 ` Vladimir Oltean
2022-04-09 3:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2022-04-08 12:46 UTC (permalink / raw)
To: Michael Walle
Cc: Claudiu Manoil, Alexandre Belloni, Andrew Lunn, Vivien Didelot,
Florian Fainelli, David S . Miller, Jakub Kicinski, Paolo Abeni,
UNGLinuxDriver, netdev, linux-kernel
On Fri, Apr 08, 2022 at 12:15:21PM +0200, Michael Walle wrote:
> The DSA master might not have been probed yet in which case the probe of
> the felix switch fails with -EPROBE_DEFER:
> [ 4.435305] mscc_felix 0000:00:00.5: Failed to register DSA switch: -517
>
> It is not an error. Use dev_err_probe() to demote this particular error
> to a debug message.
>
> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] net: dsa: felix: suppress -EPROBE_DEFER errors
2022-04-08 10:15 [PATCH net v2] net: dsa: felix: suppress -EPROBE_DEFER errors Michael Walle
2022-04-08 12:46 ` Vladimir Oltean
@ 2022-04-09 3:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-09 3:40 UTC (permalink / raw)
To: Michael Walle
Cc: vladimir.oltean, claudiu.manoil, alexandre.belloni, andrew,
vivien.didelot, f.fainelli, davem, kuba, pabeni, UNGLinuxDriver,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 8 Apr 2022 12:15:21 +0200 you wrote:
> The DSA master might not have been probed yet in which case the probe of
> the felix switch fails with -EPROBE_DEFER:
> [ 4.435305] mscc_felix 0000:00:00.5: Failed to register DSA switch: -517
>
> It is not an error. Use dev_err_probe() to demote this particular error
> to a debug message.
>
> [...]
Here is the summary with links:
- [net,v2] net: dsa: felix: suppress -EPROBE_DEFER errors
https://git.kernel.org/netdev/net/c/e6934e4048c9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-09 3:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 10:15 [PATCH net v2] net: dsa: felix: suppress -EPROBE_DEFER errors Michael Walle
2022-04-08 12:46 ` Vladimir Oltean
2022-04-09 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).