* [PATCH v4,0/2] Add mt8186 dpi compatiable
@ 2022-04-11 2:53 xinlei.lee
2022-04-11 2:53 ` [PATCH v4,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186 xinlei.lee
2022-04-11 2:53 ` [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
0 siblings, 2 replies; 5+ messages in thread
From: xinlei.lee @ 2022-04-11 2:53 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, rex-bc.chen, jitao.shi,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Base on 5.18-rc1
Change since v3:
1. Move mt8186_conf location.
Change since v2:
1. Move mt8186 compatiable location.
Change since v1:
1. Put switch dpi Topckgen MUX action in mt8186.dtsi.
Xinlei Lee (2):
dt-bindings: display: mediatek: dpi: Add compatible for MediaTek
MT8186
drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
.../bindings/display/mediatek/mediatek,dpi.yaml | 1 +
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
2 files changed, 12 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-11 2:53 [PATCH v4,0/2] Add mt8186 dpi compatiable xinlei.lee
@ 2022-04-11 2:53 ` xinlei.lee
2022-04-11 2:53 ` [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
1 sibling, 0 replies; 5+ messages in thread
From: xinlei.lee @ 2022-04-11 2:53 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, rex-bc.chen, jitao.shi,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 843f89d6053f..77ee1b923991 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt7623-dpi
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
+ - mediatek,mt8186-dpi
- mediatek,mt8192-dpi
reg:
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-11 2:53 [PATCH v4,0/2] Add mt8186 dpi compatiable xinlei.lee
2022-04-11 2:53 ` [PATCH v4,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186 xinlei.lee
@ 2022-04-11 2:53 ` xinlei.lee
2022-04-11 3:33 ` Rex-BC Chen
2022-04-12 8:20 ` CK Hu
1 sibling, 2 replies; 5+ messages in thread
From: xinlei.lee @ 2022-04-11 2:53 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, rex-bc.chen, jitao.shi,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..824d7da41c6a 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static const struct mtk_dpi_conf mt8192_conf = {
.cal_factor = mt8183_calculate_factor,
.reg_h_fre_con = 0xe0,
@@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8183-dpi",
.data = &mt8183_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-11 2:53 ` [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
@ 2022-04-11 3:33 ` Rex-BC Chen
2022-04-12 8:20 ` CK Hu
1 sibling, 0 replies; 5+ messages in thread
From: Rex-BC Chen @ 2022-04-11 3:33 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, jitao.shi,
Project_Global_Chrome_Upstream_Group
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-11 2:53 ` [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
2022-04-11 3:33 ` Rex-BC Chen
@ 2022-04-12 8:20 ` CK Hu
1 sibling, 0 replies; 5+ messages in thread
From: CK Hu @ 2022-04-12 8:20 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
Hi, Xinlei:
On Mon, 2022-04-11 at 10:53 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..824d7da41c6a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -815,6 +815,14 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
> static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> @@ -942,6 +950,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8183-dpi",
> .data = &mt8183_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
If Nicolas' patch [1] is correct, this should be
.data = &mt8192_conf,
Could you help to comfirm patch [1] is correct or not?
[1]
https://patchwork.kernel.org/project/linux-mediatek/patch/20220408013950.674477-1-nfraprado@collabora.com/
Regards,
CK
> + },
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-12 9:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 2:53 [PATCH v4,0/2] Add mt8186 dpi compatiable xinlei.lee
2022-04-11 2:53 ` [PATCH v4,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186 xinlei.lee
2022-04-11 2:53 ` [PATCH v4,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
2022-04-11 3:33 ` Rex-BC Chen
2022-04-12 8:20 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).