* [PATCH v2 0/2] Venus fixes @ 2022-04-12 13:15 Vikash Garodia 2022-04-12 13:15 ` [PATCH v2 1/2] media: venus: do not queue internal buffers from previous sequence Vikash Garodia 2022-04-12 13:15 ` [PATCH v2 2/2] media: venus: vdec: ensure venus is powered on during stream off Vikash Garodia 0 siblings, 2 replies; 4+ messages in thread From: Vikash Garodia @ 2022-04-12 13:15 UTC (permalink / raw) To: linux-media, stanimir.varbanov; +Cc: linux-kernel, quic_vgarodia Changes in this version since v1 includes: * addressed comments from Stanimir. Vikash Garodia (2): media: venus: do not queue internal buffers from previous sequence media: venus: vdec: ensure venus is powered on during stream off drivers/media/platform/qcom/venus/helpers.c | 34 +++++++++++++++++++++-------- drivers/media/platform/qcom/venus/vdec.c | 2 ++ 2 files changed, 27 insertions(+), 9 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] media: venus: do not queue internal buffers from previous sequence 2022-04-12 13:15 [PATCH v2 0/2] Venus fixes Vikash Garodia @ 2022-04-12 13:15 ` Vikash Garodia 2022-04-13 17:57 ` Fritz Koenig 2022-04-12 13:15 ` [PATCH v2 2/2] media: venus: vdec: ensure venus is powered on during stream off Vikash Garodia 1 sibling, 1 reply; 4+ messages in thread From: Vikash Garodia @ 2022-04-12 13:15 UTC (permalink / raw) To: linux-media, stanimir.varbanov; +Cc: linux-kernel, quic_vgarodia During reconfig (DRC) event from firmware, it is not guaranteed that all the DPB(internal) buffers would be released by the firmware. Some buffers might be released gradually while processing frames from the new sequence. These buffers now stay idle in the dpblist. In subsequent call to queue the DPBs to firmware, these idle buffers should not be queued. The fix identifies those buffers and free them. Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 34 +++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c index 0bca95d..fa01edd 100644 --- a/drivers/media/platform/qcom/venus/helpers.c +++ b/drivers/media/platform/qcom/venus/helpers.c @@ -90,12 +90,28 @@ bool venus_helper_check_codec(struct venus_inst *inst, u32 v4l2_pixfmt) } EXPORT_SYMBOL_GPL(venus_helper_check_codec); +static void free_dpb_buf(struct venus_inst *inst, struct intbuf *buf) +{ + ida_free(&inst->dpb_ids, buf->dpb_out_tag); + + list_del_init(&buf->list); + dma_free_attrs(inst->core->dev, buf->size, buf->va, buf->da, + buf->attrs); + kfree(buf); +} + int venus_helper_queue_dpb_bufs(struct venus_inst *inst) { - struct intbuf *buf; + struct intbuf *buf, *next; + unsigned int dpb_size = 0; int ret = 0; - list_for_each_entry(buf, &inst->dpbbufs, list) { + if (inst->dpb_buftype == HFI_BUFFER_OUTPUT) + dpb_size = inst->output_buf_size; + else if (inst->dpb_buftype == HFI_BUFFER_OUTPUT2) + dpb_size = inst->output2_buf_size; + + list_for_each_entry_safe(buf, next, &inst->dpbbufs, list) { struct hfi_frame_data fdata; memset(&fdata, 0, sizeof(fdata)); @@ -106,6 +122,12 @@ int venus_helper_queue_dpb_bufs(struct venus_inst *inst) if (buf->owned_by == FIRMWARE) continue; + /* free buffer from previous sequence which was released later */ + if (dpb_size > buf->size) { + free_dpb_buf(inst, buf); + continue; + } + fdata.clnt_data = buf->dpb_out_tag; ret = hfi_session_process_buf(inst, &fdata); @@ -127,13 +149,7 @@ int venus_helper_free_dpb_bufs(struct venus_inst *inst) list_for_each_entry_safe(buf, n, &inst->dpbbufs, list) { if (buf->owned_by == FIRMWARE) continue; - - ida_free(&inst->dpb_ids, buf->dpb_out_tag); - - list_del_init(&buf->list); - dma_free_attrs(inst->core->dev, buf->size, buf->va, buf->da, - buf->attrs); - kfree(buf); + free_dpb_buf(inst, buf); } if (list_empty(&inst->dpbbufs)) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] media: venus: do not queue internal buffers from previous sequence 2022-04-12 13:15 ` [PATCH v2 1/2] media: venus: do not queue internal buffers from previous sequence Vikash Garodia @ 2022-04-13 17:57 ` Fritz Koenig 0 siblings, 0 replies; 4+ messages in thread From: Fritz Koenig @ 2022-04-13 17:57 UTC (permalink / raw) To: Vikash Garodia; +Cc: Linux Media Mailing List, Stanimir Varbanov, LKML Tested-by: Fritz Koenig <frkoenig@chromium.org> On Tue, Apr 12, 2022 at 6:23 AM Vikash Garodia <quic_vgarodia@quicinc.com> wrote: > > During reconfig (DRC) event from firmware, it is not guaranteed that > all the DPB(internal) buffers would be released by the firmware. Some > buffers might be released gradually while processing frames from the > new sequence. These buffers now stay idle in the dpblist. > In subsequent call to queue the DPBs to firmware, these idle buffers > should not be queued. The fix identifies those buffers and free them. > > Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> > Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > --- > drivers/media/platform/qcom/venus/helpers.c | 34 +++++++++++++++++++++-------- > 1 file changed, 25 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index 0bca95d..fa01edd 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -90,12 +90,28 @@ bool venus_helper_check_codec(struct venus_inst *inst, u32 v4l2_pixfmt) > } > EXPORT_SYMBOL_GPL(venus_helper_check_codec); > > +static void free_dpb_buf(struct venus_inst *inst, struct intbuf *buf) > +{ > + ida_free(&inst->dpb_ids, buf->dpb_out_tag); > + > + list_del_init(&buf->list); > + dma_free_attrs(inst->core->dev, buf->size, buf->va, buf->da, > + buf->attrs); > + kfree(buf); > +} > + > int venus_helper_queue_dpb_bufs(struct venus_inst *inst) > { > - struct intbuf *buf; > + struct intbuf *buf, *next; > + unsigned int dpb_size = 0; > int ret = 0; > > - list_for_each_entry(buf, &inst->dpbbufs, list) { > + if (inst->dpb_buftype == HFI_BUFFER_OUTPUT) > + dpb_size = inst->output_buf_size; > + else if (inst->dpb_buftype == HFI_BUFFER_OUTPUT2) > + dpb_size = inst->output2_buf_size; > + > + list_for_each_entry_safe(buf, next, &inst->dpbbufs, list) { > struct hfi_frame_data fdata; > > memset(&fdata, 0, sizeof(fdata)); > @@ -106,6 +122,12 @@ int venus_helper_queue_dpb_bufs(struct venus_inst *inst) > if (buf->owned_by == FIRMWARE) > continue; > > + /* free buffer from previous sequence which was released later */ > + if (dpb_size > buf->size) { > + free_dpb_buf(inst, buf); > + continue; > + } > + > fdata.clnt_data = buf->dpb_out_tag; > > ret = hfi_session_process_buf(inst, &fdata); > @@ -127,13 +149,7 @@ int venus_helper_free_dpb_bufs(struct venus_inst *inst) > list_for_each_entry_safe(buf, n, &inst->dpbbufs, list) { > if (buf->owned_by == FIRMWARE) > continue; > - > - ida_free(&inst->dpb_ids, buf->dpb_out_tag); > - > - list_del_init(&buf->list); > - dma_free_attrs(inst->core->dev, buf->size, buf->va, buf->da, > - buf->attrs); > - kfree(buf); > + free_dpb_buf(inst, buf); > } > > if (list_empty(&inst->dpbbufs)) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] media: venus: vdec: ensure venus is powered on during stream off 2022-04-12 13:15 [PATCH v2 0/2] Venus fixes Vikash Garodia 2022-04-12 13:15 ` [PATCH v2 1/2] media: venus: do not queue internal buffers from previous sequence Vikash Garodia @ 2022-04-12 13:15 ` Vikash Garodia 1 sibling, 0 replies; 4+ messages in thread From: Vikash Garodia @ 2022-04-12 13:15 UTC (permalink / raw) To: linux-media, stanimir.varbanov; +Cc: linux-kernel, quic_vgarodia Video decoder driver auto-suspends the hardware if there is no exchange of command or response for certain amount of time. In auto suspended state, it becomes mandatory to power on the hardware before requesting it to process a command. The fix ensures the hardware is powered on during stop streaming. Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com> Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> --- drivers/media/platform/qcom/venus/vdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c index 91da3f5..4ac1132 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1200,6 +1200,8 @@ static void vdec_stop_streaming(struct vb2_queue *q) struct venus_inst *inst = vb2_get_drv_priv(q); int ret = -EINVAL; + vdec_pm_get_put(inst); + mutex_lock(&inst->lock); if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-13 17:57 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-04-12 13:15 [PATCH v2 0/2] Venus fixes Vikash Garodia 2022-04-12 13:15 ` [PATCH v2 1/2] media: venus: do not queue internal buffers from previous sequence Vikash Garodia 2022-04-13 17:57 ` Fritz Koenig 2022-04-12 13:15 ` [PATCH v2 2/2] media: venus: vdec: ensure venus is powered on during stream off Vikash Garodia
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).