* [PATCH v3 0/2] memory: omap-gpmc: Allow module build
@ 2022-04-11 9:55 Roger Quadros
2022-04-11 9:55 ` [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Roger Quadros @ 2022-04-11 9:55 UTC (permalink / raw)
To: krzk
Cc: miquel.raynal, tony, vigneshr, kishon, nm, linux-omap,
linux-kernel, Roger Quadros
Hi,
These patches allow OMAP_GPMC config to be visible in menuconfig
and buildable as a module.
Changelog:
v3:
- Remove not required MODULE_ALIAS
- Mention in commit message why we need to remove of_match_node() call
v2:
- Allow building as a module
Roger Quadros (2):
memory: omap-gpmc: Make OMAP_GPMC config visible and selectable
memory: omap-gpmc: Allow building as a module
drivers/memory/Kconfig | 4 ++--
drivers/memory/omap-gpmc.c | 43 ++++++++++++++++++++------------------
2 files changed, 25 insertions(+), 22 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable 2022-04-11 9:55 [PATCH v3 0/2] memory: omap-gpmc: Allow module build Roger Quadros @ 2022-04-11 9:55 ` Roger Quadros 2022-04-11 10:06 ` Miquel Raynal 2022-04-11 9:55 ` [PATCH v3 2/2] memory: omap-gpmc: Allow building as a module Roger Quadros 2022-04-13 9:43 ` [PATCH v3 0/2] memory: omap-gpmc: Allow module build Krzysztof Kozlowski 2 siblings, 1 reply; 17+ messages in thread From: Roger Quadros @ 2022-04-11 9:55 UTC (permalink / raw) To: krzk Cc: miquel.raynal, tony, vigneshr, kishon, nm, linux-omap, linux-kernel, Roger Quadros So far for armv7 TI platforms, GPMC was being selected by arch/arm/mach-* architecture Kconfig files. For K3 platforms, GPMC is no longer required for basic boot and cannot be always enabled by default by mach- Kconfig. We need a way for user (or board defconfig) to enable it if required so ake OMAP_GPMC Kconfig option always visible. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- drivers/memory/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index 30bff6cb1b8d..da2af9c38fe3 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -103,8 +103,8 @@ config TI_EMIF temperature changes config OMAP_GPMC - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST - depends on OF_ADDRESS + bool "Texas Instruments OMAP SoC GPMC driver" + depends on OF_ADDRESS || COMPILE_TEST select GPIOLIB help This driver is for the General Purpose Memory Controller (GPMC) -- 2.17.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable 2022-04-11 9:55 ` [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros @ 2022-04-11 10:06 ` Miquel Raynal 0 siblings, 0 replies; 17+ messages in thread From: Miquel Raynal @ 2022-04-11 10:06 UTC (permalink / raw) To: Roger Quadros; +Cc: krzk, tony, vigneshr, kishon, nm, linux-omap, linux-kernel Hi Roger, rogerq@kernel.org wrote on Mon, 11 Apr 2022 12:55:15 +0300: > So far for armv7 TI platforms, GPMC was being selected by > arch/arm/mach-* architecture Kconfig files. > > For K3 platforms, GPMC is no longer required for basic boot > and cannot be always enabled by default by mach- Kconfig. > > We need a way for user (or board defconfig) to enable > it if required so ake OMAP_GPMC Kconfig option always visible. make Otherwise, Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > drivers/memory/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index 30bff6cb1b8d..da2af9c38fe3 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -103,8 +103,8 @@ config TI_EMIF > temperature changes > > config OMAP_GPMC > - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST > - depends on OF_ADDRESS > + bool "Texas Instruments OMAP SoC GPMC driver" > + depends on OF_ADDRESS || COMPILE_TEST > select GPIOLIB > help > This driver is for the General Purpose Memory Controller (GPMC) Thanks, Miquèl ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v3 2/2] memory: omap-gpmc: Allow building as a module 2022-04-11 9:55 [PATCH v3 0/2] memory: omap-gpmc: Allow module build Roger Quadros 2022-04-11 9:55 ` [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros @ 2022-04-11 9:55 ` Roger Quadros 2022-04-13 9:43 ` [PATCH v3 0/2] memory: omap-gpmc: Allow module build Krzysztof Kozlowski 2 siblings, 0 replies; 17+ messages in thread From: Roger Quadros @ 2022-04-11 9:55 UTC (permalink / raw) To: krzk Cc: miquel.raynal, tony, vigneshr, kishon, nm, linux-omap, linux-kernel, Roger Quadros Allow OMAP_GPMC to be built as a module. When building this driver as a module, the symbol 'of_default_bus_match_table' will not be found as it is not being exported. The of_match_node() call is redundant anyways as of_platform_default_populate() already takes care of matching with 'of_default_bus_match_table'. So get rid of that call. This will also resolve the module build failure. Move compatible match table to the end where it is usually expected. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- drivers/memory/Kconfig | 2 +- drivers/memory/omap-gpmc.c | 43 ++++++++++++++++++++------------------ 2 files changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index da2af9c38fe3..4debd4b2c8da 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -103,7 +103,7 @@ config TI_EMIF temperature changes config OMAP_GPMC - bool "Texas Instruments OMAP SoC GPMC driver" + tristate "Texas Instruments OMAP SoC GPMC driver" depends on OF_ADDRESS || COMPILE_TEST select GPIOLIB help diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index ed11887c1b7c..de41c9795fb8 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -12,6 +12,7 @@ #include <linux/cpu_pm.h> #include <linux/irq.h> #include <linux/kernel.h> +#include <linux/module.h> #include <linux/init.h> #include <linux/err.h> #include <linux/clk.h> @@ -1889,16 +1890,6 @@ int gpmc_cs_program_settings(int cs, struct gpmc_settings *p) } #ifdef CONFIG_OF -static const struct of_device_id gpmc_dt_ids[] = { - { .compatible = "ti,omap2420-gpmc" }, - { .compatible = "ti,omap2430-gpmc" }, - { .compatible = "ti,omap3430-gpmc" }, /* omap3430 & omap3630 */ - { .compatible = "ti,omap4430-gpmc" }, /* omap4430 & omap4460 & omap543x */ - { .compatible = "ti,am3352-gpmc" }, /* am335x devices */ - { .compatible = "ti,am64-gpmc" }, - { } -}; - static void gpmc_cs_set_name(int cs, const char *name) { struct gpmc_cs_data *gpmc = &gpmc_cs[cs]; @@ -2257,11 +2248,9 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, if (!of_platform_device_create(child, NULL, &pdev->dev)) goto err_child_fail; - /* is child a common bus? */ - if (of_match_node(of_default_bus_match_table, child)) - /* create children and other common bus children */ - if (of_platform_default_populate(child, NULL, &pdev->dev)) - goto err_child_fail; + /* create children and other common bus children */ + if (of_platform_default_populate(child, NULL, &pdev->dev)) + goto err_child_fail; return 0; @@ -2278,6 +2267,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, return ret; } +static const struct of_device_id gpmc_dt_ids[]; + static int gpmc_probe_dt(struct platform_device *pdev) { int ret; @@ -2644,6 +2635,19 @@ static int gpmc_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(gpmc_pm_ops, gpmc_suspend, gpmc_resume); +#ifdef CONFIG_OF +static const struct of_device_id gpmc_dt_ids[] = { + { .compatible = "ti,omap2420-gpmc" }, + { .compatible = "ti,omap2430-gpmc" }, + { .compatible = "ti,omap3430-gpmc" }, /* omap3430 & omap3630 */ + { .compatible = "ti,omap4430-gpmc" }, /* omap4430 & omap4460 & omap543x */ + { .compatible = "ti,am3352-gpmc" }, /* am335x devices */ + { .compatible = "ti,am64-gpmc" }, + { } +}; +MODULE_DEVICE_TABLE(of, gpmc_dt_ids); +#endif + static struct platform_driver gpmc_driver = { .probe = gpmc_probe, .remove = gpmc_remove, @@ -2654,8 +2658,7 @@ static struct platform_driver gpmc_driver = { }, }; -static __init int gpmc_init(void) -{ - return platform_driver_register(&gpmc_driver); -} -postcore_initcall(gpmc_init); +module_platform_driver(gpmc_driver); + +MODULE_DESCRIPTION("Texas Instruments GPMC driver"); +MODULE_LICENSE("GPL v2"); -- 2.17.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-11 9:55 [PATCH v3 0/2] memory: omap-gpmc: Allow module build Roger Quadros 2022-04-11 9:55 ` [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros 2022-04-11 9:55 ` [PATCH v3 2/2] memory: omap-gpmc: Allow building as a module Roger Quadros @ 2022-04-13 9:43 ` Krzysztof Kozlowski 2022-04-13 9:50 ` Krzysztof Kozlowski 2 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 9:43 UTC (permalink / raw) To: Roger Quadros, krzk Cc: Krzysztof Kozlowski, linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: > These patches allow OMAP_GPMC config to be visible in menuconfig > and buildable as a module. > > Changelog: > v3: > - Remove not required MODULE_ALIAS > - Mention in commit message why we need to remove of_match_node() call > > [...] Applied, thanks! [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable commit: 656d1be692be78b825954e0a2a47fcae81834633 [2/2] memory: omap-gpmc: Allow building as a module commit: eb55c7180be67774aa728a3c450de441e0dedb5d Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 9:43 ` [PATCH v3 0/2] memory: omap-gpmc: Allow module build Krzysztof Kozlowski @ 2022-04-13 9:50 ` Krzysztof Kozlowski 2022-04-13 10:20 ` Krzysztof Kozlowski 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 9:50 UTC (permalink / raw) To: Roger Quadros, krzk Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 11:43, Krzysztof Kozlowski wrote: > On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >> These patches allow OMAP_GPMC config to be visible in menuconfig >> and buildable as a module. >> >> Changelog: >> v3: >> - Remove not required MODULE_ALIAS >> - Mention in commit message why we need to remove of_match_node() call >> >> [...] > > Applied, thanks! > > [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable > commit: 656d1be692be78b825954e0a2a47fcae81834633 > [2/2] memory: omap-gpmc: Allow building as a module > commit: eb55c7180be67774aa728a3c450de441e0dedb5d And dropped. You have a checkpatch issue: WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #127: FILE: drivers/memory/omap-gpmc.c:2664: +MODULE_LICENSE("GPL v2"); Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 9:50 ` Krzysztof Kozlowski @ 2022-04-13 10:20 ` Krzysztof Kozlowski 2022-04-13 10:42 ` Roger Quadros 2022-04-13 11:01 ` Roger Quadros 0 siblings, 2 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 10:20 UTC (permalink / raw) To: Roger Quadros, krzk Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 11:50, Krzysztof Kozlowski wrote: > On 13/04/2022 11:43, Krzysztof Kozlowski wrote: >> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >>> These patches allow OMAP_GPMC config to be visible in menuconfig >>> and buildable as a module. >>> >>> Changelog: >>> v3: >>> - Remove not required MODULE_ALIAS >>> - Mention in commit message why we need to remove of_match_node() call >>> >>> [...] >> >> Applied, thanks! >> >> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable >> commit: 656d1be692be78b825954e0a2a47fcae81834633 >> [2/2] memory: omap-gpmc: Allow building as a module >> commit: eb55c7180be67774aa728a3c450de441e0dedb5d > > And dropped. You have a checkpatch issue: > > WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: > Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > #127: FILE: drivers/memory/omap-gpmc.c:2664: > +MODULE_LICENSE("GPL v2"); I kept your first patch (visible/selectable) but I think it should be dropped as well. You need to test it more: https://krzk.eu/#/builders/63/builds/162 Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 10:20 ` Krzysztof Kozlowski @ 2022-04-13 10:42 ` Roger Quadros 2022-04-13 11:01 ` Roger Quadros 1 sibling, 0 replies; 17+ messages in thread From: Roger Quadros @ 2022-04-13 10:42 UTC (permalink / raw) To: Krzysztof Kozlowski, krzk Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr Hi Krzysztof, On 13/04/2022 13:20, Krzysztof Kozlowski wrote: > On 13/04/2022 11:50, Krzysztof Kozlowski wrote: >> On 13/04/2022 11:43, Krzysztof Kozlowski wrote: >>> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >>>> These patches allow OMAP_GPMC config to be visible in menuconfig >>>> and buildable as a module. >>>> >>>> Changelog: >>>> v3: >>>> - Remove not required MODULE_ALIAS >>>> - Mention in commit message why we need to remove of_match_node() call >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable >>> commit: 656d1be692be78b825954e0a2a47fcae81834633 >>> [2/2] memory: omap-gpmc: Allow building as a module >>> commit: eb55c7180be67774aa728a3c450de441e0dedb5d >> >> And dropped. You have a checkpatch issue: >> >> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: >> Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") >> #127: FILE: drivers/memory/omap-gpmc.c:2664: >> +MODULE_LICENSE("GPL v2"); > > I kept your first patch (visible/selectable) but I think it should be > dropped as well. You need to test it more: > > https://krzk.eu/#/builders/63/builds/162 Thanks for the report. I will fix the issues. cheers, -roger ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 10:20 ` Krzysztof Kozlowski 2022-04-13 10:42 ` Roger Quadros @ 2022-04-13 11:01 ` Roger Quadros 2022-04-13 11:05 ` Krzysztof Kozlowski 1 sibling, 1 reply; 17+ messages in thread From: Roger Quadros @ 2022-04-13 11:01 UTC (permalink / raw) To: Krzysztof Kozlowski, krzk Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 13:20, Krzysztof Kozlowski wrote: > On 13/04/2022 11:50, Krzysztof Kozlowski wrote: >> On 13/04/2022 11:43, Krzysztof Kozlowski wrote: >>> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >>>> These patches allow OMAP_GPMC config to be visible in menuconfig >>>> and buildable as a module. >>>> >>>> Changelog: >>>> v3: >>>> - Remove not required MODULE_ALIAS >>>> - Mention in commit message why we need to remove of_match_node() call >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable >>> commit: 656d1be692be78b825954e0a2a47fcae81834633 >>> [2/2] memory: omap-gpmc: Allow building as a module >>> commit: eb55c7180be67774aa728a3c450de441e0dedb5d >> >> And dropped. You have a checkpatch issue: >> >> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: >> Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") >> #127: FILE: drivers/memory/omap-gpmc.c:2664: >> +MODULE_LICENSE("GPL v2"); > > I kept your first patch (visible/selectable) but I think it should be > dropped as well. You need to test it more: > > https://krzk.eu/#/builders/63/builds/162 > > >> config OMAP_GPMC >> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >> - depends on OF_ADDRESS >> + bool "Texas Instruments OMAP SoC GPMC driver" >> + depends on OF_ADDRESS || COMPILE_TEST Looks like include/linux/irqdomain.h does not have fallbacks if CONFIG_IRQ_DOMAIN is not enabled. I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN. Is that OK? cheers, -roger ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 11:01 ` Roger Quadros @ 2022-04-13 11:05 ` Krzysztof Kozlowski 2022-04-13 11:33 ` Roger Quadros 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 11:05 UTC (permalink / raw) To: Roger Quadros, krzk Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 13:01, Roger Quadros wrote: >> https://krzk.eu/#/builders/63/builds/162 >> >> >>> config OMAP_GPMC >>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>> - depends on OF_ADDRESS >>> + bool "Texas Instruments OMAP SoC GPMC driver" >>> + depends on OF_ADDRESS || COMPILE_TEST > > > Looks like include/linux/irqdomain.h does not have fallbacks if > CONFIG_IRQ_DOMAIN is not enabled. > > I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN. > Is that OK? Previously it was building with COMPILE_TEST on sparc, so what else changed? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 11:05 ` Krzysztof Kozlowski @ 2022-04-13 11:33 ` Roger Quadros 2022-04-13 11:47 ` Krzysztof Kozlowski 0 siblings, 1 reply; 17+ messages in thread From: Roger Quadros @ 2022-04-13 11:33 UTC (permalink / raw) To: Krzysztof Kozlowski, krzk Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 14:05, Krzysztof Kozlowski wrote: > On 13/04/2022 13:01, Roger Quadros wrote: >>> https://krzk.eu/#/builders/63/builds/162 >>> >>> >>>> config OMAP_GPMC >>>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>>> - depends on OF_ADDRESS >>>> + bool "Texas Instruments OMAP SoC GPMC driver" >>>> + depends on OF_ADDRESS || COMPILE_TEST >> >> >> Looks like include/linux/irqdomain.h does not have fallbacks if >> CONFIG_IRQ_DOMAIN is not enabled. >> >> I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN. >> Is that OK? > > Previously it was building with COMPILE_TEST on sparc, so what else changed? > Previously it was like so bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST depends on OF_ADDRESS Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. And OF_ADDRESS is not set for sparc config OF_ADDRESS def_bool y depends on !SPARC && (HAS_IOMEM || UML) cheers, -roger ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 11:33 ` Roger Quadros @ 2022-04-13 11:47 ` Krzysztof Kozlowski 2022-04-13 11:56 ` Roger Quadros 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 11:47 UTC (permalink / raw) To: Roger Quadros, Krzysztof Kozlowski Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 13:33, Roger Quadros wrote: >> Previously it was building with COMPILE_TEST on sparc, so what else changed? >> > Previously it was like so > > bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST > depends on OF_ADDRESS > > Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. > > And OF_ADDRESS is not set for sparc > Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other "depends" here. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 11:47 ` Krzysztof Kozlowski @ 2022-04-13 11:56 ` Roger Quadros 2022-04-13 12:31 ` Krzysztof Kozlowski 0 siblings, 1 reply; 17+ messages in thread From: Roger Quadros @ 2022-04-13 11:56 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 14:47, Krzysztof Kozlowski wrote: > On 13/04/2022 13:33, Roger Quadros wrote: >>> Previously it was building with COMPILE_TEST on sparc, so what else changed? >>> >> Previously it was like so >> >> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >> depends on OF_ADDRESS >> >> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. >> >> And OF_ADDRESS is not set for sparc >> > > Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other > "depends" here. But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN is enabled. It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right? cheers, -roger ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 11:56 ` Roger Quadros @ 2022-04-13 12:31 ` Krzysztof Kozlowski 2022-04-13 12:56 ` Roger Quadros 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 12:31 UTC (permalink / raw) To: Roger Quadros Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 13:56, Roger Quadros wrote: > > > On 13/04/2022 14:47, Krzysztof Kozlowski wrote: >> On 13/04/2022 13:33, Roger Quadros wrote: >>>> Previously it was building with COMPILE_TEST on sparc, so what else changed? >>>> >>> Previously it was like so >>> >>> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>> depends on OF_ADDRESS >>> >>> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. >>> >>> And OF_ADDRESS is not set for sparc >>> >> >> Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other >> "depends" here. > > But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN > is enabled. > > It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right? I must admit I did not dig this that much. OF_ADDRESS has !SPARC dependency, so after removing COMPILE_TEST the issue should not happen on SPARC. What about other platforms? They should behave I think the same as before - fail if they were failing. Nothing gets worse which is my main concern here. If you have spare time, maybe you could investigate the compile testing on other platforms as well and if something fails, fix it. But it seems it is separate problem. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 12:31 ` Krzysztof Kozlowski @ 2022-04-13 12:56 ` Roger Quadros 2022-04-13 13:00 ` Krzysztof Kozlowski 0 siblings, 1 reply; 17+ messages in thread From: Roger Quadros @ 2022-04-13 12:56 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 15:31, Krzysztof Kozlowski wrote: > On 13/04/2022 13:56, Roger Quadros wrote: >> >> >> On 13/04/2022 14:47, Krzysztof Kozlowski wrote: >>> On 13/04/2022 13:33, Roger Quadros wrote: >>>>> Previously it was building with COMPILE_TEST on sparc, so what else changed? >>>>> >>>> Previously it was like so >>>> >>>> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>>> depends on OF_ADDRESS >>>> >>>> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. >>>> >>>> And OF_ADDRESS is not set for sparc >>>> >>> >>> Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other >>> "depends" here. >> >> But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN >> is enabled. >> >> It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right? > > I must admit I did not dig this that much. OF_ADDRESS has !SPARC > dependency, so after removing COMPILE_TEST the issue should not happen > on SPARC. What about other platforms? They should behave I think the > same as before - fail if they were failing. Nothing gets worse which is > my main concern here. > > If you have spare time, maybe you could investigate the compile testing > on other platforms as well and if something fails, fix it. But it seems > it is separate problem. > I won't be able to test on all platforms. I'm ok to not add more dependency and just drop COMPILE_TEST. cheers, -roger ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 12:56 ` Roger Quadros @ 2022-04-13 13:00 ` Krzysztof Kozlowski 2022-04-13 13:04 ` Krzysztof Kozlowski 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 13:00 UTC (permalink / raw) To: Roger Quadros Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 14:56, Roger Quadros wrote: >> >> If you have spare time, maybe you could investigate the compile testing >> on other platforms as well and if something fails, fix it. But it seems >> it is separate problem. >> > > I won't be able to test on all platforms. I'm ok to not add more dependency and > just drop COMPILE_TEST. I understand that. You can still test 8-12 popular ones on a regular Ubuntu machine (there are like 10 or 12 cross compile toolchains now in standard Ubuntu repos). Another way is to put your patches on Github and ask kbuild folks to test your trees. I think this was the repo (but double check): https://github.com/fengguang/lkp-tests Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build 2022-04-13 13:00 ` Krzysztof Kozlowski @ 2022-04-13 13:04 ` Krzysztof Kozlowski 0 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-04-13 13:04 UTC (permalink / raw) To: Roger Quadros Cc: linux-omap, nm, linux-kernel, kishon, tony, miquel.raynal, vigneshr On 13/04/2022 15:00, Krzysztof Kozlowski wrote: > I understand that. You can still test 8-12 popular ones on a regular > Ubuntu machine (there are like 10 or 12 cross compile toolchains now in > standard Ubuntu repos). > > Another way is to put your patches on Github and ask kbuild folks to > test your trees. I think this was the repo (but double check): > https://github.com/fengguang/lkp-tests I think this is correct one: https://github.com/intel/lkp-tests.git Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-04-13 13:05 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-04-11 9:55 [PATCH v3 0/2] memory: omap-gpmc: Allow module build Roger Quadros 2022-04-11 9:55 ` [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros 2022-04-11 10:06 ` Miquel Raynal 2022-04-11 9:55 ` [PATCH v3 2/2] memory: omap-gpmc: Allow building as a module Roger Quadros 2022-04-13 9:43 ` [PATCH v3 0/2] memory: omap-gpmc: Allow module build Krzysztof Kozlowski 2022-04-13 9:50 ` Krzysztof Kozlowski 2022-04-13 10:20 ` Krzysztof Kozlowski 2022-04-13 10:42 ` Roger Quadros 2022-04-13 11:01 ` Roger Quadros 2022-04-13 11:05 ` Krzysztof Kozlowski 2022-04-13 11:33 ` Roger Quadros 2022-04-13 11:47 ` Krzysztof Kozlowski 2022-04-13 11:56 ` Roger Quadros 2022-04-13 12:31 ` Krzysztof Kozlowski 2022-04-13 12:56 ` Roger Quadros 2022-04-13 13:00 ` Krzysztof Kozlowski 2022-04-13 13:04 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).