[PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[YC Hung]

From: "YC Hung" <yc.hung@mediatek.com>

This patch adds mt8195 dsp document. The dsp is used for Sound Open
Firmware driver node. It includes registers,  clocks, memory regions,
and mailbox for dsp.

Signed-off-by: yc.hung <yc.hung@mediatek.com>
---
Changes since v3:
  Fix patch v3 error : v3 only provide difference between v3 and v2.

Changes since v2:
  Remove useless watchdog interrupt.
  Add commit message more detail description.

Changes since v1:
  Rename yaml file name as mediatek,mt8195-dsp.yaml
  Refine descriptions for mailbox, memory-region and drop unused labels
  in examples.
---
 .../bindings/dsp/mediatek,mt8195-dsp.yaml     | 105 ++++++++++++++++++
 1 file changed, 105 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml

diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
new file mode 100644
index 000000000000..b7e68b0dfa13
--- /dev/null
+++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dsp/mediatek,mt8195-dsp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek mt8195 DSP core
+
+maintainers:
+  - YC Hung <yc.hung@mediatek.com>
+
+description: |
+  Some boards from mt8195 contain a DSP core used for
+  advanced pre- and post- audio processing.
+
+properties:
+  compatible:
+    const: mediatek,mt8195-dsp
+
+  reg:
+    items:
+      - description: Address and size of the DSP Cfg registers
+      - description: Address and size of the DSP SRAM
+
+  reg-names:
+    items:
+      - const: cfg
+      - const: sram
+
+  clocks:
+    items:
+      - description: mux for audio dsp clock
+      - description: 26M clock
+      - description: mux for audio dsp local bus
+      - description: default audio dsp local bus clock source
+      - description: clock gate for audio dsp clock
+      - description: mux for audio dsp access external bus
+
+  clock-names:
+    items:
+      - const: adsp_sel
+      - const: clk26m_ck
+      - const: audio_local_bus
+      - const: mainpll_d7_d2
+      - const: scp_adsp_audiodsp
+      - const: audio_h
+
+  power-domains:
+    maxItems: 1
+
+  mboxes:
+    items:
+      - description: ipc reply between host and audio DSP.
+      - description: ipc request between host and audio DSP.
+
+  mbox-names:
+    items:
+      - const: mbox0
+      - const: mbox1
+
+  memory-region:
+    items:
+      - description: dma buffer between host and DSP.
+      - description: DSP system memory.
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - clocks
+  - clock-names
+  - memory-region
+  - power-domains
+  - mbox-names
+  - mboxes
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    dsp@10803000 {
+       compatible =  "mediatek,mt8195-dsp";
+       reg = <0x10803000  0x1000>,
+             <0x10840000  0x40000>;
+       reg-names = "cfg", "sram";
+       clocks = <&topckgen 10>, //CLK_TOP_ADSP
+                <&clk26m>,
+                <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
+                <&topckgen 136>, //CLK_TOP_MAINPLL_D7_D2
+                <&scp_adsp 0>, //CLK_SCP_ADSP_AUDIODSP
+                <&topckgen 34>; //CLK_TOP_AUDIO_H
+       clock-names = "adsp_sel",
+                     "clk26m_ck",
+                     "audio_local_bus",
+                     "mainpll_d7_d2",
+                     "scp_adsp_audiodsp",
+                     "audio_h";
+       memory-region = <&adsp_dma_mem_reserved>,
+                       <&adsp_mem_reserved>;
+       power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
+       mbox-names = "mbox0", "mbox1";
+       mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
+    };
-- 
2.18.0

Re: [PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[Rob Herring]

On Thu, 06 Jan 2022 14:48:48 +0800, YC Hung wrote:
> From: "YC Hung" <yc.hung@mediatek.com>
> 
> This patch adds mt8195 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers,  clocks, memory regions,
> and mailbox for dsp.
> 
> Signed-off-by: yc.hung <yc.hung@mediatek.com>
> ---
> Changes since v3:
>   Fix patch v3 error : v3 only provide difference between v3 and v2.
> 
> Changes since v2:
>   Remove useless watchdog interrupt.
>   Add commit message more detail description.
> 
> Changes since v1:
>   Rename yaml file name as mediatek,mt8195-dsp.yaml
>   Refine descriptions for mailbox, memory-region and drop unused labels
>   in examples.
> ---
>  .../bindings/dsp/mediatek,mt8195-dsp.yaml     | 105 ++++++++++++++++++
>  1 file changed, 105 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[Matthias Brugger]

On 12/01/2022 02:43, Rob Herring wrote:
> On Thu, 06 Jan 2022 14:48:48 +0800, YC Hung wrote:
>> From: "YC Hung" <yc.hung@mediatek.com>
>>
>> This patch adds mt8195 dsp document. The dsp is used for Sound Open
>> Firmware driver node. It includes registers,  clocks, memory regions,
>> and mailbox for dsp.
>>
>> Signed-off-by: yc.hung <yc.hung@mediatek.com>
>> ---
>> Changes since v3:
>>    Fix patch v3 error : v3 only provide difference between v3 and v2.
>>
>> Changes since v2:
>>    Remove useless watchdog interrupt.
>>    Add commit message more detail description.
>>
>> Changes since v1:
>>    Rename yaml file name as mediatek,mt8195-dsp.yaml
>>    Refine descriptions for mailbox, memory-region and drop unused labels
>>    in examples.
>> ---
>>   .../bindings/dsp/mediatek,mt8195-dsp.yaml     | 105 ++++++++++++++++++
>>   1 file changed, 105 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

Rob, it seems we don't have a maintainer for this bindings. Shall I as MediaTek 
SoC maintainer take them through my branch?

Regards,
Matthias

Re: [PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[YC Hung]

Hi Mattias/Rob,

Sorry I miss this mail.
Could you please help to check this patch? Thanks.

On Fri, 2022-01-14 at 13:56 +0100, Matthias Brugger wrote:
> 
> On 12/01/2022 02:43, Rob Herring wrote:
> > On Thu, 06 Jan 2022 14:48:48 +0800, YC Hung wrote:
> > > From: "YC Hung" <yc.hung@mediatek.com>
> > > 
> > > This patch adds mt8195 dsp document. The dsp is used for Sound
> > > Open
> > > Firmware driver node. It includes registers,  clocks, memory
> > > regions,
> > > and mailbox for dsp.
> > > 
> > > Signed-off-by: yc.hung <yc.hung@mediatek.com>
> > > ---
> > > Changes since v3:
> > >    Fix patch v3 error : v3 only provide difference between v3 and
> > > v2.
> > > 
> > > Changes since v2:
> > >    Remove useless watchdog interrupt.
> > >    Add commit message more detail description.
> > > 
> > > Changes since v1:
> > >    Rename yaml file name as mediatek,mt8195-dsp.yaml
> > >    Refine descriptions for mailbox, memory-region and drop unused
> > > labels
> > >    in examples.
> > > ---
> > >   .../bindings/dsp/mediatek,mt8195-dsp.yaml     | 105
> > > ++++++++++++++++++
> > >   1 file changed, 105 insertions(+)
> > >   create mode 100644
> > > Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> > > 
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> 
> Rob, it seems we don't have a maintainer for this bindings. Shall I
> as MediaTek 
> SoC maintainer take them through my branch?
> 
> Regards,
> Matthias

Re: [PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[Matthias Brugger]

Hi,

On 29/04/2022 07:59, YC Hung wrote:
> Hi Mattias/Rob,
> 
> Sorry I miss this mail.
> Could you please help to check this patch? Thanks.
> 

Rob gave his reviewed-by. I just saw that the driver maintainer is Mark, so I 
expect him to take the patch through his tree. Didn't realized this beforehand.

Regards,
Matthias

> On Fri, 2022-01-14 at 13:56 +0100, Matthias Brugger wrote:
>>
>> On 12/01/2022 02:43, Rob Herring wrote:
>>> On Thu, 06 Jan 2022 14:48:48 +0800, YC Hung wrote:
>>>> From: "YC Hung" <yc.hung@mediatek.com>
>>>>
>>>> This patch adds mt8195 dsp document. The dsp is used for Sound
>>>> Open
>>>> Firmware driver node. It includes registers,  clocks, memory
>>>> regions,
>>>> and mailbox for dsp.
>>>>
>>>> Signed-off-by: yc.hung <yc.hung@mediatek.com>
>>>> ---
>>>> Changes since v3:
>>>>     Fix patch v3 error : v3 only provide difference between v3 and
>>>> v2.
>>>>
>>>> Changes since v2:
>>>>     Remove useless watchdog interrupt.
>>>>     Add commit message more detail description.
>>>>
>>>> Changes since v1:
>>>>     Rename yaml file name as mediatek,mt8195-dsp.yaml
>>>>     Refine descriptions for mailbox, memory-region and drop unused
>>>> labels
>>>>     in examples.
>>>> ---
>>>>    .../bindings/dsp/mediatek,mt8195-dsp.yaml     | 105
>>>> ++++++++++++++++++
>>>>    1 file changed, 105 insertions(+)
>>>>    create mode 100644
>>>> Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
>>>>
>>>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>
>>
>> Rob, it seems we don't have a maintainer for this bindings. Shall I
>> as MediaTek
>> SoC maintainer take them through my branch?
>>
>> Regards,
>> Matthias
> 

Re: [PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Fri, Apr 29, 2022 at 02:57:12PM +0200, Matthias Brugger wrote:
> On 29/04/2022 07:59, YC Hung wrote:

> > Sorry I miss this mail.
> > Could you please help to check this patch? Thanks.

> Rob gave his reviewed-by. I just saw that the driver maintainer is Mark, so
> I expect him to take the patch through his tree. Didn't realized this
> beforehand.

TBH I'd missed this since there was nothing in the subject line that
drew my attention to it.  Seen it now though.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4] dt-bindings: dsp: mediatek: add mt8195 dsp document

[Mark Brown]

On Thu, 6 Jan 2022 14:48:48 +0800, YC Hung wrote:
> From: "YC Hung" <yc.hung@mediatek.com>
> 
> This patch adds mt8195 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers,  clocks, memory regions,
> and mailbox for dsp.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] dt-bindings: dsp: mediatek: add mt8195 dsp document
      commit: 66727cdb250ec5d3f42558e33ace5c7d0fbd9477

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark