linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: dpt_i2o: Drop redundant spinlock initialization
@ 2022-05-10  9:47 Haowen Bai
  2022-05-20  1:09 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-05-10  9:47 UTC (permalink / raw)
  To: Adaptec OEM Raid Solutions, James E.J. Bottomley, Martin K. Petersen
  Cc: Haowen Bai, linux-scsi, linux-kernel

adpt_post_wait_lock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/scsi/dpt_i2o.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 93227c04ef59..2e9155ba7408 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1000,7 +1000,6 @@ static int adpt_install_hba(struct scsi_host_template* sht, struct pci_dev* pDev
 
 	// Initializing the spinlocks
 	spin_lock_init(&pHba->state_lock);
-	spin_lock_init(&adpt_post_wait_lock);
 
 	if(raptorFlag == 0){
 		printk(KERN_INFO "Adaptec I2O RAID controller"
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: dpt_i2o: Drop redundant spinlock initialization
  2022-05-10  9:47 [PATCH] scsi: dpt_i2o: Drop redundant spinlock initialization Haowen Bai
@ 2022-05-20  1:09 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-05-20  1:09 UTC (permalink / raw)
  To: Haowen Bai, James E.J. Bottomley, Adaptec OEM Raid Solutions
  Cc: Martin K . Petersen, linux-scsi, linux-kernel

On Tue, 10 May 2022 17:47:03 +0800, Haowen Bai wrote:

> adpt_post_wait_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: dpt_i2o: Drop redundant spinlock initialization
      https://git.kernel.org/mkp/scsi/c/91fdd0788878

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-20  1:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10  9:47 [PATCH] scsi: dpt_i2o: Drop redundant spinlock initialization Haowen Bai
2022-05-20  1:09 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).