* [PATCH] ia64: mca: Drop redundant spinlock initialization
@ 2022-05-10 9:51 Haowen Bai
0 siblings, 0 replies; 2+ messages in thread
From: Haowen Bai @ 2022-05-10 9:51 UTC (permalink / raw)
Cc: Haowen Bai, linux-ia64, linux-kernel
mlogbuf_rlock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
arch/ia64/kernel/mca.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c
index e628a88607bb..c62a66710ad6 100644
--- a/arch/ia64/kernel/mca.c
+++ b/arch/ia64/kernel/mca.c
@@ -290,7 +290,6 @@ static void ia64_mlogbuf_finish(int wait)
{
BREAK_LOGLEVEL(console_loglevel);
- spin_lock_init(&mlogbuf_rlock);
ia64_mlogbuf_dump();
printk(KERN_EMERG "mlogbuf_finish: printing switched to urgent mode, "
"MCA/INIT might be dodgy or fail.\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ia64: mca: Drop redundant spinlock initialization
@ 2022-05-10 10:01 Haowen Bai
0 siblings, 0 replies; 2+ messages in thread
From: Haowen Bai @ 2022-05-10 10:01 UTC (permalink / raw)
To: will, peterz, daniel.thompson, bristot
Cc: linux-ia64, linux-kernel, Haowen Bai
mlogbuf_rlock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
arch/ia64/kernel/mca.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c
index e628a88607bb..c62a66710ad6 100644
--- a/arch/ia64/kernel/mca.c
+++ b/arch/ia64/kernel/mca.c
@@ -290,7 +290,6 @@ static void ia64_mlogbuf_finish(int wait)
{
BREAK_LOGLEVEL(console_loglevel);
- spin_lock_init(&mlogbuf_rlock);
ia64_mlogbuf_dump();
printk(KERN_EMERG "mlogbuf_finish: printing switched to urgent mode, "
"MCA/INIT might be dodgy or fail.\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-10 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 9:51 [PATCH] ia64: mca: Drop redundant spinlock initialization Haowen Bai
2022-05-10 10:01 Haowen Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).