* [PATCH] MIPS: VR41xx: Drop redundant spinlock initialization
@ 2022-05-10 9:55 Haowen Bai
2022-05-12 16:08 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-05-10 9:55 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: Haowen Bai, linux-mips, linux-kernel
slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
arch/mips/vr41xx/common/cmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
index b59ee5479313..e4cbe116b26d 100644
--- a/arch/mips/vr41xx/common/cmu.c
+++ b/arch/mips/vr41xx/common/cmu.c
@@ -236,8 +236,6 @@ static int __init vr41xx_cmu_init(void)
if (current_cpu_type() == CPU_VR4133)
cmuclkmsk2 = cmu_read(CMUCLKMSK2);
- spin_lock_init(&cmu_lock);
-
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: VR41xx: Drop redundant spinlock initialization
2022-05-10 9:55 [PATCH] MIPS: VR41xx: Drop redundant spinlock initialization Haowen Bai
@ 2022-05-12 16:08 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2022-05-12 16:08 UTC (permalink / raw)
To: Haowen Bai; +Cc: linux-mips, linux-kernel
On Tue, May 10, 2022 at 05:55:27PM +0800, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> arch/mips/vr41xx/common/cmu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
> index b59ee5479313..e4cbe116b26d 100644
> --- a/arch/mips/vr41xx/common/cmu.c
> +++ b/arch/mips/vr41xx/common/cmu.c
> @@ -236,8 +236,6 @@ static int __init vr41xx_cmu_init(void)
> if (current_cpu_type() == CPU_VR4133)
> cmuclkmsk2 = cmu_read(CMUCLKMSK2);
>
> - spin_lock_init(&cmu_lock);
> -
> return 0;
> }
>
> --
> 2.7.4
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-12 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 9:55 [PATCH] MIPS: VR41xx: Drop redundant spinlock initialization Haowen Bai
2022-05-12 16:08 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).