From: Satya Priya <quic_c_skakit@quicinc.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<swboyd@chromium.org>, <quic_collinsd@quicinc.com>,
<quic_subbaram@quicinc.com>, <quic_jprakash@quicinc.com>,
Satya Priya <quic_c_skakit@quicinc.com>
Subject: [PATCH V12 4/9] mfd: pm8008: Add reset-gpios
Date: Wed, 11 May 2022 18:48:28 +0530 [thread overview]
Message-ID: <1652275113-10277-5-git-send-email-quic_c_skakit@quicinc.com> (raw)
In-Reply-To: <1652275113-10277-1-git-send-email-quic_c_skakit@quicinc.com>
Add the reset-gpio toggling in the pm8008_probe() to bring
pm8008 chip out of reset instead of doing it in DT node using
"output-high" property.
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes in V12:
- Move reset_gpio acquiring above probe_irq_peripherals in pm8008_probe.
Changes in V11:
- Use local variable for reset_gpios as it is not used outside of probe.
- Use GPIOD_OUT_LOW flag to initialize the gpio and remove below line
as it is not required "gpiod_set_value(chip->reset_gpio, 1);".
Changes in V10:
- This has been split from [V9,3/6] as per comments here [1]
[1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649166633-25872-4-git-send-email-quic_c_skakit@quicinc.com/#24803409
drivers/mfd/qcom-pm8008.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index c472d7f..5a670b0 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -4,6 +4,7 @@
*/
#include <linux/bitops.h>
+#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
@@ -221,6 +222,7 @@ static int pm8008_probe(struct i2c_client *client)
{
int rc;
struct pm8008_data *chip;
+ struct gpio_desc *reset_gpio;
chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
if (!chip)
@@ -233,6 +235,10 @@ static int pm8008_probe(struct i2c_client *client)
i2c_set_clientdata(client, chip);
+ reset_gpio = devm_gpiod_get(chip->dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(reset_gpio))
+ return PTR_ERR(reset_gpio);
+
if (of_property_read_bool(chip->dev->of_node, "interrupt-controller")) {
rc = pm8008_probe_irq_peripherals(chip, client->irq);
if (rc)
--
2.7.4
next prev parent reply other threads:[~2022-05-11 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:18 [PATCH V12 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-05-11 13:18 ` [PATCH V12 1/9] dt-bindings: mfd: pm8008: Add reset-gpios Satya Priya
2022-05-11 13:18 ` [PATCH V12 2/9] dt-bindings: mfd: pm8008: Change the address cells Satya Priya
2022-05-17 17:54 ` Rob Herring
2022-05-11 13:18 ` [PATCH V12 3/9] dt-bindings: mfd: pm8008: Add regulators for pm8008 Satya Priya
2022-05-17 17:55 ` Rob Herring
2022-05-11 13:18 ` Satya Priya [this message]
2022-05-11 13:18 ` [PATCH V12 5/9] mfd: pm8008: Remove the regmap member from pm8008_data struct Satya Priya
2022-05-11 13:18 ` [PATCH V12 6/9] mfd: pm8008: Use i2c_new_dummy_device() API Satya Priya
2022-05-16 18:56 ` Stephen Boyd
2022-05-11 13:18 ` [PATCH V12 7/9] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-05-16 12:12 ` Dan Carpenter
2022-05-16 19:03 ` Stephen Boyd
2022-05-19 12:06 ` Satya Priya Kakitapalli (Temp)
2022-05-11 13:18 ` [PATCH V12 8/9] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-05-11 13:18 ` [PATCH V12 9/9] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652275113-10277-5-git-send-email-quic_c_skakit@quicinc.com \
--to=quic_c_skakit@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).