linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Satya Priya <quic_c_skakit@quicinc.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, swboyd@chromium.org,
	quic_collinsd@quicinc.com, quic_subbaram@quicinc.com,
	quic_jprakash@quicinc.com,
	Satya Priya <quic_c_skakit@quicinc.com>
Subject: Re: [PATCH V12 7/9] regulator: Add a regulator driver for the PM8008 PMIC
Date: Mon, 16 May 2022 15:12:05 +0300	[thread overview]
Message-ID: <202205130908.O31s3mhc-lkp@intel.com> (raw)
In-Reply-To: <1652275113-10277-8-git-send-email-quic_c_skakit@quicinc.com>

Hi Satya,

url:    https://github.com/intel-lab-lkp/linux/commits/Satya-Priya/Add-Qualcomm-Technologies-Inc-PM8008-regulator-driver/20220511-212136
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: nios2-randconfig-m031-20220512 (https://download.01.org/0day-ci/archive/20220513/202205130908.O31s3mhc-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/regulator/qcom-pm8008-regulator.c:174 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)

Old smatch warnings:
drivers/regulator/qcom-pm8008-regulator.c:175 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:176 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:178 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:180 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:180 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:182 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:186 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)
drivers/regulator/qcom-pm8008-regulator.c:196 pm8008_regulator_probe() error: buffer overflow 'reg_data' 7 <= 7 (assuming for loop doesn't break)

vim +174 drivers/regulator/qcom-pm8008-regulator.c

3337142527c77d Satya Priya 2022-05-11  122  static int pm8008_regulator_probe(struct platform_device *pdev)
3337142527c77d Satya Priya 2022-05-11  123  {
3337142527c77d Satya Priya 2022-05-11  124  	int rc, i;
3337142527c77d Satya Priya 2022-05-11  125  	u32 base;
3337142527c77d Satya Priya 2022-05-11  126  	unsigned int reg;
3337142527c77d Satya Priya 2022-05-11  127  	const char *name;
3337142527c77d Satya Priya 2022-05-11  128  	struct device *dev = &pdev->dev;
3337142527c77d Satya Priya 2022-05-11  129  	struct regulator_config reg_config = {};
3337142527c77d Satya Priya 2022-05-11  130  	struct regulator_dev    *rdev;
3337142527c77d Satya Priya 2022-05-11  131  	const struct pm8008_data *chip = dev_get_drvdata(pdev->dev.parent);
3337142527c77d Satya Priya 2022-05-11  132  	struct pm8008_regulator *pm8008_reg;
3337142527c77d Satya Priya 2022-05-11  133  
3337142527c77d Satya Priya 2022-05-11  134  	pm8008_reg = devm_kzalloc(dev, sizeof(*pm8008_reg), GFP_KERNEL);
3337142527c77d Satya Priya 2022-05-11  135  	if (!pm8008_reg)
3337142527c77d Satya Priya 2022-05-11  136  		return -ENOMEM;
3337142527c77d Satya Priya 2022-05-11  137  
3337142527c77d Satya Priya 2022-05-11  138  	pm8008_reg->regmap = pm8008_get_regmap(chip);
3337142527c77d Satya Priya 2022-05-11  139  	if (!pm8008_reg->regmap) {
3337142527c77d Satya Priya 2022-05-11  140  		dev_err(dev, "parent regmap is missing\n");
3337142527c77d Satya Priya 2022-05-11  141  		return -EINVAL;
3337142527c77d Satya Priya 2022-05-11  142  	}
3337142527c77d Satya Priya 2022-05-11  143  
3337142527c77d Satya Priya 2022-05-11  144  	pm8008_reg->dev = dev;
3337142527c77d Satya Priya 2022-05-11  145  
3337142527c77d Satya Priya 2022-05-11  146  	rc = of_property_read_string(dev->of_node, "regulator-name", &name);
3337142527c77d Satya Priya 2022-05-11  147  	if (rc)
3337142527c77d Satya Priya 2022-05-11  148  		return rc;
3337142527c77d Satya Priya 2022-05-11  149  
3337142527c77d Satya Priya 2022-05-11  150  	/* get the required regulator data */
3337142527c77d Satya Priya 2022-05-11  151  	for (i = 0; i < ARRAY_SIZE(reg_data); i++)
3337142527c77d Satya Priya 2022-05-11  152  		if (strstr(name, reg_data[i].name))
3337142527c77d Satya Priya 2022-05-11  153  			break;

This code assumes that we will find a match but it would be more robust
to add a check.

	if (i == ARRAY_SIZE(reg_data))
		return -ENODEV;

3337142527c77d Satya Priya 2022-05-11  154  
3337142527c77d Satya Priya 2022-05-11  155  	rc = of_property_read_u32_index(dev->of_node, "reg", 1, &base);
3337142527c77d Satya Priya 2022-05-11  156  	if (rc < 0) {
3337142527c77d Satya Priya 2022-05-11  157  		dev_err(dev, "%s: failed to get regulator base rc=%d\n", name, rc);
3337142527c77d Satya Priya 2022-05-11  158  		return rc;
3337142527c77d Satya Priya 2022-05-11  159  	}
3337142527c77d Satya Priya 2022-05-11  160  	pm8008_reg->base = base;
3337142527c77d Satya Priya 2022-05-11  161  
3337142527c77d Satya Priya 2022-05-11  162  	/* get slew rate */
3337142527c77d Satya Priya 2022-05-11  163  	rc = regmap_bulk_read(pm8008_reg->regmap,
3337142527c77d Satya Priya 2022-05-11  164  			LDO_STEPPER_CTL_REG(pm8008_reg->base), &reg, 1);
3337142527c77d Satya Priya 2022-05-11  165  	if (rc < 0) {
3337142527c77d Satya Priya 2022-05-11  166  		dev_err(dev, "failed to read step rate configuration rc=%d\n", rc);
3337142527c77d Satya Priya 2022-05-11  167  		return rc;
3337142527c77d Satya Priya 2022-05-11  168  	}
3337142527c77d Satya Priya 2022-05-11  169  	reg &= STEP_RATE_MASK;
3337142527c77d Satya Priya 2022-05-11  170  	pm8008_reg->step_rate = DEFAULT_VOLTAGE_STEPPER_RATE >> reg;
3337142527c77d Satya Priya 2022-05-11  171  
3337142527c77d Satya Priya 2022-05-11  172  	pm8008_reg->rdesc.type = REGULATOR_VOLTAGE;
3337142527c77d Satya Priya 2022-05-11  173  	pm8008_reg->rdesc.ops = &pm8008_regulator_ops;
3337142527c77d Satya Priya 2022-05-11 @174  	pm8008_reg->rdesc.name = reg_data[i].name;
3337142527c77d Satya Priya 2022-05-11  175  	pm8008_reg->rdesc.supply_name = reg_data[i].supply_name;
3337142527c77d Satya Priya 2022-05-11  176  	pm8008_reg->rdesc.of_match = reg_data[i].name;
3337142527c77d Satya Priya 2022-05-11  177  	pm8008_reg->rdesc.uV_step = VSET_STEP_UV;
3337142527c77d Satya Priya 2022-05-11  178  	pm8008_reg->rdesc.min_uV = reg_data[i].min_uv;
3337142527c77d Satya Priya 2022-05-11  179  	pm8008_reg->rdesc.n_voltages
3337142527c77d Satya Priya 2022-05-11  180  		= ((reg_data[i].max_uv - reg_data[i].min_uv)
3337142527c77d Satya Priya 2022-05-11  181  			/ pm8008_reg->rdesc.uV_step) + 1;
3337142527c77d Satya Priya 2022-05-11  182  	pm8008_reg->rdesc.linear_ranges = reg_data[i].voltage_range;
3337142527c77d Satya Priya 2022-05-11  183  	pm8008_reg->rdesc.n_linear_ranges = 1;
3337142527c77d Satya Priya 2022-05-11  184  	pm8008_reg->rdesc.enable_reg = LDO_ENABLE_REG(pm8008_reg->base);
3337142527c77d Satya Priya 2022-05-11  185  	pm8008_reg->rdesc.enable_mask = ENABLE_BIT;
3337142527c77d Satya Priya 2022-05-11  186  	pm8008_reg->rdesc.min_dropout_uV = reg_data[i].min_dropout_uv;
3337142527c77d Satya Priya 2022-05-11  187  	pm8008_reg->voltage_selector = -ENOTRECOVERABLE;
3337142527c77d Satya Priya 2022-05-11  188  
3337142527c77d Satya Priya 2022-05-11  189  	reg_config.dev = dev->parent;
3337142527c77d Satya Priya 2022-05-11  190  	reg_config.driver_data = pm8008_reg;
3337142527c77d Satya Priya 2022-05-11  191  	reg_config.regmap = pm8008_reg->regmap;
3337142527c77d Satya Priya 2022-05-11  192  
3337142527c77d Satya Priya 2022-05-11  193  	rdev = devm_regulator_register(dev, &pm8008_reg->rdesc, &reg_config);
3337142527c77d Satya Priya 2022-05-11  194  	if (IS_ERR(rdev)) {
3337142527c77d Satya Priya 2022-05-11  195  		rc = PTR_ERR(rdev);
3337142527c77d Satya Priya 2022-05-11  196  		dev_err(dev, "%s: failed to register regulator rc=%d\n",
3337142527c77d Satya Priya 2022-05-11  197  				reg_data[i].name, rc);
3337142527c77d Satya Priya 2022-05-11  198  		return rc;
3337142527c77d Satya Priya 2022-05-11  199  	}
3337142527c77d Satya Priya 2022-05-11  200  
3337142527c77d Satya Priya 2022-05-11  201  	return 0;
3337142527c77d Satya Priya 2022-05-11  202  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


  reply	other threads:[~2022-05-16 12:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 13:18 [PATCH V12 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-05-11 13:18 ` [PATCH V12 1/9] dt-bindings: mfd: pm8008: Add reset-gpios Satya Priya
2022-05-11 13:18 ` [PATCH V12 2/9] dt-bindings: mfd: pm8008: Change the address cells Satya Priya
2022-05-17 17:54   ` Rob Herring
2022-05-11 13:18 ` [PATCH V12 3/9] dt-bindings: mfd: pm8008: Add regulators for pm8008 Satya Priya
2022-05-17 17:55   ` Rob Herring
2022-05-11 13:18 ` [PATCH V12 4/9] mfd: pm8008: Add reset-gpios Satya Priya
2022-05-11 13:18 ` [PATCH V12 5/9] mfd: pm8008: Remove the regmap member from pm8008_data struct Satya Priya
2022-05-11 13:18 ` [PATCH V12 6/9] mfd: pm8008: Use i2c_new_dummy_device() API Satya Priya
2022-05-16 18:56   ` Stephen Boyd
2022-05-11 13:18 ` [PATCH V12 7/9] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-05-16 12:12   ` Dan Carpenter [this message]
2022-05-16 19:03   ` Stephen Boyd
2022-05-19 12:06     ` Satya Priya Kakitapalli (Temp)
2022-05-11 13:18 ` [PATCH V12 8/9] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-05-11 13:18 ` [PATCH V12 9/9] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202205130908.O31s3mhc-lkp@intel.com \
    --to=dan.carpenter@oracle.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=quic_c_skakit@quicinc.com \
    --cc=quic_collinsd@quicinc.com \
    --cc=quic_jprakash@quicinc.com \
    --cc=quic_subbaram@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).