linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Fix ethernet on production Quartz64-B
@ 2022-06-06 16:30 Peter Geis
  2022-06-07  9:19 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Geis @ 2022-06-06 16:30 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Peter Geis
  Cc: Frank Mankel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

The production Quartz64 Model B has compatibility issues when using
rgmii-id mode. Switch to rgmii mode and use the SoC's delays to ensure
full compatibility.

Reported-by: Frank Mankel <frank.mankel@gmail.com>
Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device
tree")
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Frank Mankel <frank.mankel@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 7bdcecc0dfe4..02d5f5a8ca03 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -133,7 +133,7 @@ &gmac1 {
 	assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru SCLK_GMAC1>;
 	assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru SCLK_GMAC1>, <&gmac1_clkin>;
 	clock_in_out = "input";
-	phy-mode = "rgmii-id";
+	phy-mode = "rgmii";
 	phy-supply = <&vcc_3v3>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac1m1_miim
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Fix ethernet on production Quartz64-B
  2022-06-06 16:30 [PATCH] arm64: dts: rockchip: Fix ethernet on production Quartz64-B Peter Geis
@ 2022-06-07  9:19 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2022-06-07  9:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Peter Geis
  Cc: Heiko Stuebner, devicetree, linux-arm-kernel, Frank Mankel,
	linux-rockchip, linux-kernel

On Mon, 6 Jun 2022 12:30:23 -0400, Peter Geis wrote:
> The production Quartz64 Model B has compatibility issues when using
> rgmii-id mode. Switch to rgmii mode and use the SoC's delays to ensure
> full compatibility.

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix ethernet on production Quartz64-B
      commit: 16bc4d196b2a8960cac3bdfd4c98d72c44ab043b

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-07  9:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-06 16:30 [PATCH] arm64: dts: rockchip: Fix ethernet on production Quartz64-B Peter Geis
2022-06-07  9:19 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).