* [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
@ 2022-06-29 6:24 sunying
2022-06-29 6:50 ` Christoph Hellwig
2022-06-29 14:36 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: sunying @ 2022-06-29 6:24 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Ying Sun
From: Ying Sun <sunying@nj.iscas.ac.cn>
The configuration item BLK_RQ_IO_DATA_LEN is not declared in the kernel.
Select BLK_RQ_IO_DATA_LEN is meaningless which could be removed.
Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
---
block/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/Kconfig b/block/Kconfig
index 50b17e260fa2..444c5ab3b67e 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -147,7 +147,6 @@ config BLK_CGROUP_FC_APPID
config BLK_CGROUP_IOCOST
bool "Enable support for cost model based cgroup IO controller"
depends on BLK_CGROUP
- select BLK_RQ_IO_DATA_LEN
select BLK_RQ_ALLOC_TIME
help
Enabling this option enables the .weight interface for cost
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
2022-06-29 6:24 [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency sunying
@ 2022-06-29 6:50 ` Christoph Hellwig
2022-06-29 14:36 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-06-29 6:50 UTC (permalink / raw)
To: sunying; +Cc: axboe, linux-block, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
2022-06-29 6:24 [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency sunying
2022-06-29 6:50 ` Christoph Hellwig
@ 2022-06-29 14:36 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-06-29 14:36 UTC (permalink / raw)
To: sunying; +Cc: linux-kernel, linux-block
On Wed, 29 Jun 2022 14:24:09 +0800, sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
>
> The configuration item BLK_RQ_IO_DATA_LEN is not declared in the kernel.
> Select BLK_RQ_IO_DATA_LEN is meaningless which could be removed.
>
>
Applied, thanks!
[1/1] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
commit: b9a1c179bdfa133d28ab8b7d30631b0accdc2057
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-29 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 6:24 [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency sunying
2022-06-29 6:50 ` Christoph Hellwig
2022-06-29 14:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).