linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dmaengine: imx-sdma: Add missing struct documentation
@ 2022-07-06  5:45 Shengjiu Wang
  2022-07-06 16:28 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Shengjiu Wang @ 2022-07-06  5:45 UTC (permalink / raw)
  To: vkoul, shawnguo, s.hauer, kernel, festevam, shengjiu.wang,
	linux-imx, dmaengine
  Cc: linux-arm-kernel, linux-kernel

Fix compile warning that 'Function parameter or member not described'
with 'W=1' option:

Add missing description for struct sdma_desc

There is not any description for struct sdma_script_start_addrs,
so use /* instead of /**

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
changes in v2
- refine the patch title

 drivers/dma/imx-sdma.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 8535018ee7a2..39d70ef1caf0 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -188,7 +188,7 @@
 #define SDMA_DONE0_CONFIG_DONE_SEL	BIT(7)
 #define SDMA_DONE0_CONFIG_DONE_DIS	BIT(6)
 
-/**
+/*
  * struct sdma_script_start_addrs - SDMA script start pointers
  *
  * start addresses of the different functions in the physical
@@ -424,6 +424,11 @@ struct sdma_desc {
  * @data:		specific sdma interface structure
  * @bd_pool:		dma_pool for bd
  * @terminate_worker:	used to call back into terminate work function
+ * @terminated:		terminated list
+ * @is_ram_script:	flag for script in ram
+ * @n_fifos_src:	number of source device fifos
+ * @n_fifos_dst:	number of destination device fifos
+ * @sw_done:		software done flag
  */
 struct sdma_channel {
 	struct virt_dma_chan		vc;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] dmaengine: imx-sdma: Add missing struct documentation
  2022-07-06  5:45 [PATCH v2] dmaengine: imx-sdma: Add missing struct documentation Shengjiu Wang
@ 2022-07-06 16:28 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-07-06 16:28 UTC (permalink / raw)
  To: Shengjiu Wang
  Cc: shawnguo, s.hauer, kernel, festevam, shengjiu.wang, linux-imx,
	dmaengine, linux-arm-kernel, linux-kernel

On 06-07-22, 13:45, Shengjiu Wang wrote:
> Fix compile warning that 'Function parameter or member not described'
> with 'W=1' option:
> 
> Add missing description for struct sdma_desc
> 
> There is not any description for struct sdma_script_start_addrs,
> so use /* instead of /**

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-06 16:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06  5:45 [PATCH v2] dmaengine: imx-sdma: Add missing struct documentation Shengjiu Wang
2022-07-06 16:28 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).